Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TypeScript typings builtin #692

Merged
merged 1 commit into from
Jan 15, 2021
Merged

feat: add TypeScript typings builtin #692

merged 1 commit into from
Jan 15, 2021

Conversation

theoludwig
Copy link
Contributor

@theoludwig theoludwig commented Jan 12, 2021

What changes this PR introduce ?

@theoludwig theoludwig requested a review from giuseppeg as a code owner January 12, 2021 20:15
@theoludwig
Copy link
Contributor Author

@Timer 👀

Copy link
Collaborator

@giuseppeg giuseppeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We should add attribution to the original author on those files.
Perhaps add a comment at the top of each file that you copied over from @types/styled-jsx

giuseppeg
giuseppeg previously approved these changes Jan 15, 2021
@theoludwig
Copy link
Contributor Author

Everything should be fine now! 👍

@giuseppeg giuseppeg merged commit 4dd5c13 into vercel:master Jan 15, 2021
@giuseppeg
Copy link
Collaborator

Yep! Thank you for the PR and patience :)

@theoludwig theoludwig deleted the feature/typings-builtin branch January 15, 2021 12:20
@github-actions
Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@theoludwig
Copy link
Contributor Author

theoludwig commented Jan 15, 2021

We've got that nice TypeScript icon on npm now! 🎉
Capture1_46

Oops, seems like the typings folder is not included in the npm package, since you're using files array properties in package.json, I didn't know that, because by default it would be included.

I just installed the package in a test folder to see what's inside node_modules :
Capture1_45

Excuse me for this mistake. 😞 @giuseppeg

The only things that need to change is to add a new item in the array with the value : "typings"

styled-jsx/package.json

Lines 7 to 18 in 4dd5c13

"files": [
"dist",
"lib",
"server.js",
"babel.js",
"babel-test.js",
"style.js",
"macro.js",
"css.js",
"webpack.js",
"license.md"
],

@giuseppeg
Copy link
Collaborator

@theoludwig theoludwig mentioned this pull request Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants