-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TypeScript typings builtin #692
Conversation
@Timer 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! We should add attribution to the original author on those files.
Perhaps add a comment at the top of each file that you copied over from @types/styled-jsx
Everything should be fine now! 👍 |
Yep! Thank you for the PR and patience :) |
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We've got that nice TypeScript icon on Oops, seems like the I just installed the package in a test folder to see what's inside Excuse me for this mistake. 😞 @giuseppeg The only things that need to change is to add a new item in the array with the value : Lines 7 to 18 in 4dd5c13
|
@divlo no worries. Here's the fix https://github.com/vercel/styled-jsx/pull/694/files |
What changes this PR introduce ?
See Is it alive? #688 (comment).
package-lock.json
in.npmrc
since there wasn't apackage-lock.json
file