Fix esternal styles with expressions are not transpiled #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that when using interpolation in external files eg. `div { color: ${colors.foo} }` we replace the interpolation `${colors.foo}` with a placeholder so that it can be parsed as css.
For external files we also check whether the export is a string or rather valid css (we do css detection). The problem was that the placeholder is invalid css eg. `div { color: %foo% } }` (`%foo%` is not a valid value for color) so we skipped the file altogether.
I fixed it by using a fake css custom property as placeholder instead.
nkzawa
approved these changes
Jun 4, 2017
This was referenced Jun 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that when using interpolation in external files eg.
div { color: ${colors.foo} }we replace the interpolation${colors.foo}with a placeholder so that it can be parsed as css.For external files we also check whether the export is a string or rather valid css (we do css detection). The problem was that the placeholder is invalid css eg.
div { color: %foo% } }(%foo%is not a valid value for color) so we skipped the file altogether.I fixed it by using a fake css custom property as placeholder instead.
Fixes #215 #220 #219 (the last two are fixed because of the stylis version bump)