Fix ASI after a colon #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR in stylis: thysultan/stylis#33 |
giuseppeg
reviewed
Jun 7, 2017
package.json
Outdated
| @@ -62,7 +62,7 @@ | |||
| "escape-string-regexp": "1.0.5", | |||
| "source-map": "0.5.6", | |||
| "string-hash": "1.1.1", | |||
| "stylis": "3.0.15" | |||
| "stylis": "^3.0.17" | |||
There was a problem hiding this comment.
please pin this version, i.e. remove the ^
giuseppeg
requested changes
Jun 7, 2017
giuseppeg
reviewed
Jun 7, 2017
yarn.lock
Outdated
| stylis@3.0.15: | ||
| version "3.0.15" | ||
| resolved "https://registry.yarnpkg.com/stylis/-/stylis-3.0.15.tgz#e0f9bf403048511043b479d39422c835141e0fbb" | ||
| stylis@^3.0.17: |
There was a problem hiding this comment.
you should update this too
There was a problem hiding this comment.
Sorry, that's the limit of what I can do on my phone 😉 I'll take care of this later when I'm in front of the PC.
There was a problem hiding this comment.
hah, ok no worries. Thank you!
|
I installed manually and updated the |
|
@fatfisz thank you for helping out!! I'll release today or tomorrow - I need to squeeze in another fix. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression compared to 0.5.7, where this worked correctly:
One of the newer versions of styled-jsx broke this - a semicolon is added after
background-image:.This is fixed in stylis 3.0.17. This branch updates stylis and adds a test to prevent regressions.