Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plugins #291

Merged
merged 10 commits into from
Oct 15, 2017
Merged

Add support for plugins #291

merged 10 commits into from
Oct 15, 2017

Conversation

giuseppeg
Copy link
Collaborator

Fixes #182

Details available at #182 This version only works at compile time - I don't think that we should implement any runtime support right now (or ever).

@giuseppeg giuseppeg requested a review from nkzawa October 1, 2017 10:11
@giuseppeg giuseppeg mentioned this pull request Oct 1, 2017
readme.md Outdated
}
```

In order to resolve local plugins paths you can use NodeJS' [require.resolve](https://nodejs.org/api/globals.html#globals_require_resolve).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be inconvenient since you can't use JS on .babrlrc. Tho it looks like .babelrc.js will be supported on v7.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, or you can make a preset

Copy link
Contributor

@nkzawa nkzawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

@giuseppeg
Copy link
Collaborator Author

please don't merge this, I want to add a small thing and write a sample plugin first.

@giuseppeg giuseppeg merged commit 8add7a5 into master Oct 15, 2017
@giuseppeg giuseppeg deleted the plugins branch October 15, 2017 16:05
This was referenced Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants