Fix hashes should match when using a single tag #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @timneutkens |
|
Could you do a new release after merging. Then we can add it to next v4 👌 |
|
@rauchg I should have tested with next-news before merging. Did you find any bug? I just saw https://github.com/zeit/styled-jsx/tree/revert-292-fix-hash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is only a single
styletag per component we stillhashStringits hash (since we always dohashString(hashes)wherehashesis an array). The resulting hash is used to scope CSS.However the
styleIdforJSXStylethen used justhashes[0]resulting in something like this:Instead with this fix it will match:
Again, this was an issue only when there was a single
styletag per component. When there are multiple it is normal thatstyleIdand the hash in the css don't match