Sanitize dynamic styles #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Feb 6, 2018
src/stylesheet-registry.js
Outdated
| // Sanitize SSR-ed and client side (style tags) CSS. | ||
| // When using optimize for speed we don't need to sanitize | ||
| // because we are not inserting markup in the DOM. | ||
| if (!this._isBrowser || !this._optimizeForSpeed) { |
There was a problem hiding this comment.
Why not in the browser? Just curious 🙏
There was a problem hiding this comment.
document.createTextNode will do the job for us in browser 😉
There was a problem hiding this comment.
!this._isBrowser == server side rendering
There was a problem hiding this comment.
indeed I can also remove the second !this._optimizeForSpeed. Client side code should be safe because of document.createTextNode (dev) and the CSS OM api not injecting DOM (prod)
OlliV
approved these changes
Feb 7, 2018
|
@timneutkens just released |
|
@giuseppeg will upgrade in next 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not going to sanitize dynamic props on the client when using CSSOM API since we don't inject dom/strings.