Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move server-only method to server file #485

Closed
wants to merge 1 commit into from
Closed

Move server-only method to server file #485

wants to merge 1 commit into from

Conversation

timneutkens
Copy link
Member

It seems like this method was only used in the server flusher, so it's not needed to ship this extra code to the client side.

@timneutkens timneutkens requested a review from giuseppeg as a code owner August 31, 2018 11:38
giuseppeg
giuseppeg reviewed Aug 31, 2018
View reviewed changes
Copy link
Collaborator

@giuseppeg giuseppeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this is a breaking change since somebody could rely on flush being exported by src/style.

Is this change really necessary? I mean flush is 5LOC

@timneutkens
Copy link
Member Author

timneutkens commented Aug 31, 2018 •
edited
Loading

Let's merge it for styled-jsx v4 then 👍 But it was never documented and styled-jsx/server was always recommended.

@rauchg rauchg closed this Jan 2, 2019
@rauchg rauchg reopened this Jan 2, 2019
@rauchg rauchg added the WIP label Jan 2, 2019
@jamestalmage
Copy link

jamestalmage commented Jun 14, 2019 •
edited
Loading

I also removed in #563. Since we're abandoning the Singleton instance, this method isn't even possible anymore.

If that is merged, this can be closed.

@huozhi huozhi mentioned this pull request Aug 31, 2021
Merged
@huozhi
Copy link
Member

huozhi commented Oct 27, 2021

Closed as it's resolved in the new achitecture in v5 beta

@huozhi huozhi closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppeg giuseppeg giuseppeg left review comments

Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timneutkens @jamestalmage @huozhi @giuseppeg @rauchg