Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tweak types #806

Merged
merged 2 commits into from
Aug 11, 2022
Merged

fix: tweak types #806

merged 2 commits into from
Aug 11, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 10, 2022

x-ref: vercel/next.js#39474

declare module wasn't picked up by typescript

  • Add global.d.ts
  • Move react style types overriding into global.d.ts
  • Scope react types in index.d.ts

@huozhi huozhi requested a review from giuseppeg as a code owner August 10, 2022 23:53
@huozhi huozhi requested a review from ijjk August 10, 2022 23:54
ijjk
ijjk reviewed Aug 11, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@huozhi huozhi merged commit 865ba14 into main Aug 11, 2022
@huozhi huozhi deleted the tweak-types branch August 11, 2022 14:17
@huozhi huozhi mentioned this pull request Aug 11, 2022
Merged
@pawelgoc pawelgoc mentioned this pull request Sep 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijjk ijjk ijjk approved these changes

@giuseppeg giuseppeg Awaiting requested review from giuseppeg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huozhi @ijjk