fix #3030 and run relateive test in edge-runtime #3036

promer94 · 2024-11-05T08:25:38Z

This pr intends to fix the inconsistent behavoir of swr's hash in edge-runtime dev mode.

The reason for this problem is because we're using node.js to simulate the edge-runtime for local development

The global Array and Object of edge-runtime are injected from node.js and the JS engine does not use global Array/Object constructor while building an array/object literal.

Then in dev mode

[].constructor !== Array.constructor
{}.construrtor !== Object.contructor

So we need find alternative to determine whether a key is an array or a plain object

codesandbox-ci · 2024-11-05T08:26:10Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

socket-security · 2024-11-05T08:26:26Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@edge-runtime/jest-environment@3.0.4	Transitive: environment, eval, unsafe	`+51`	2.18 MB	kikobeats

View full report↗︎

test/unit/serialize.test.ts

src/_internal/utils/hash.ts

huozhi

Can you add a PR description and some comments about the change in hash? It's important for others to understand the approach and grab the context when they read the code later unless directly by reading the code

package.json

src/_internal/utils/hash.ts

Co-authored-by: Toru Kobayashi <koba0004@gmail.com>

package.json

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://github.com/vercel/swr)) | dependencies | minor | [`2.2.5` -> `2.3.0`](https://renovatebot.com/diffs/npm/swr/2.2.5/2.3.0) | --- ### Release Notes <details> <summary>vercel/swr (swr)</summary> ### [`v2.3.0`](https://github.com/vercel/swr/releases/tag/v2.3.0) [Compare Source](vercel/swr@v2.2.5...v2.3.0) ##### Feature - Support promises as fallback data by [@shuding](https://github.com/shuding) in vercel/swr#2891 - Allow to use with React 19 by [@vladshcherbin](https://github.com/vladshcherbin) and [@devjiwonchoi](https://github.com/devjiwonchoi) in vercel/swr#3047, vercel/swr#2963 ##### Patches - fix [#3030](vercel/swr#3030) and run relateive test in edge-runtime by [@promer94](https://github.com/promer94) in vercel/swr#3036 - fix: Only suspend when using the `fallback` by [@shuding](https://github.com/shuding) in vercel/swr#3045 - fix type check in tests by [@huozhi](https://github.com/huozhi) in vercel/swr#3052 - fix: Replace the deprecated 'window' with 'globalThis' for Deno by [@saul-atomrigs](https://github.com/saul-atomrigs) in vercel/swr#2915 - fix: check if config.fallback is undefined by [@taku-hatano](https://github.com/taku-hatano) in vercel/swr#2913 - fix(infinte): export SWRInfiniteKeyedMutator type by [@LeoMcA](https://github.com/LeoMcA) in vercel/swr#2900 - fix: Improve comparison performance by [@shuding](https://github.com/shuding) in vercel/swr#2973 - Export ScopedMutator type by [@joshkel](https://github.com/joshkel) in vercel/swr#2937 - Improve-Type-Safety-and-State-Access-in-useStateWithDeps-Hook by [@O-BERNARDOFOEGBU](https://github.com/O-BERNARDOFOEGBU) in vercel/swr#3027 ##### Misc - chore: bump dev deps and change example react version to latest by [@huozhi](https://github.com/huozhi) in vercel/swr#2894 - build: fix beta release job by [@huozhi](https://github.com/huozhi) in vercel/swr#2895 - chore: Improve test coverage by [@shuding](https://github.com/shuding) in vercel/swr#2903 - chore: simplify test coverage strategy by [@huozhi](https://github.com/huozhi) in vercel/swr#2909 - build: simplify react-server export and update bundler by [@huozhi](https://github.com/huozhi) in vercel/swr#2897 - examples: add RSC streaming pre-render with promise fallback example by [@promer94](https://github.com/promer94) in vercel/swr#2905 - Drop client-only by [@huozhi](https://github.com/huozhi) in vercel/swr#2910 - Mark package as side-effect free by [@htunnicliff](https://github.com/htunnicliff) in vercel/swr#2904 - Drop exports module field by [@huozhi](https://github.com/huozhi) in vercel/swr#2911 - chore: update pkg script watch by [@unliar](https://github.com/unliar) in vercel/swr#2920 - test: remove console.error times check by [@promer94](https://github.com/promer94) in vercel/swr#2918 - build: bump bundler for perf by [@huozhi](https://github.com/huozhi) in vercel/swr#2929 - Fix bundling of client entry chunks by [@huozhi](https://github.com/huozhi) in vercel/swr#2932 - ci: fix ci error and upgrade action version by [@promer94](https://github.com/promer94) in vercel/swr#2952 - Add SWRInfiniteMutatorOptions type to export by [@ludwigbacklund](https://github.com/ludwigbacklund) in vercel/swr#2954 - test: update the revalidate function test for useSWRInfinite by [@koba04](https://github.com/koba04) in vercel/swr#2955 - chore: upgrade nextjs dev dep for e2e testing by [@huozhi](https://github.com/huozhi) in vercel/swr#3044 - ci: simplify ci config and bump some deps version by [@promer94](https://github.com/promer94) in vercel/swr#2770 - chore: reorganize entries by [@huozhi](https://github.com/huozhi) in vercel/swr#3048 - Bump bundler and reorganize serialize exports by [@huozhi](https://github.com/huozhi) in vercel/swr#3049 - upgrade use-sync-external-store to support react 19 by [@huozhi](https://github.com/huozhi) in vercel/swr#3050 #### New Contributors - [@htunnicliff](https://github.com/htunnicliff) made their first contribution in vercel/swr#2904 - [@saul-atomrigs](https://github.com/saul-atomrigs) made their first contribution in vercel/swr#2915 - [@unliar](https://github.com/unliar) made their first contribution in vercel/swr#2920 - [@ludwigbacklund](https://github.com/ludwigbacklund) made their first contribution in vercel/swr#2954 - [@taku-hatano](https://github.com/taku-hatano) made their first contribution in vercel/swr#2913 - [@LeoMcA](https://github.com/LeoMcA) made their first contribution in vercel/swr#2900 - [@devjiwonchoi](https://github.com/devjiwonchoi) made their first contribution in vercel/swr#2963 - [@vladshcherbin](https://github.com/vladshcherbin) made their first contribution in vercel/swr#3047 - [@O-BERNARDOFOEGBU](https://github.com/O-BERNARDOFOEGBU) made their first contribution in vercel/swr#3027 **Full Changelog**: vercel/swr@v2.2.5...v2.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/413 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>

promer94 requested review from shuding and huozhi as code owners November 5, 2024 08:25

promer94 requested a review from koba04 November 7, 2024 07:03

koba04 reviewed Nov 10, 2024

View reviewed changes

test/unit/serialize.test.ts Show resolved Hide resolved

koba04 reviewed Nov 14, 2024

View reviewed changes

src/_internal/utils/hash.ts Outdated Show resolved Hide resolved

huozhi reviewed Nov 14, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/_internal/utils/hash.ts Outdated Show resolved Hide resolved

src/_internal/utils/hash.ts Show resolved Hide resolved

fix #3030 and run relateive test in edge-runtime

6c1ce59

Co-authored-by: Toru Kobayashi <koba0004@gmail.com>

promer94 force-pushed the fix-3030 branch from 4dc6956 to 6c1ce59 Compare November 15, 2024 07:30

apply code review

47ac9f0

huozhi reviewed Nov 23, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

sync with main

2136e52

promer94 requested review from koba04 and huozhi November 25, 2024 07:41

huozhi approved these changes Nov 25, 2024

View reviewed changes

huozhi merged commit bd839a4 into main Nov 25, 2024
7 checks passed

huozhi deleted the fix-3030 branch November 25, 2024 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix #3030 and run relateive test in edge-runtime #3036

fix #3030 and run relateive test in edge-runtime #3036

promer94 commented Nov 5, 2024 •

edited

Loading

codesandbox-ci bot commented Nov 5, 2024 •

edited

Loading

socket-security bot commented Nov 5, 2024 •

edited

Loading

huozhi left a comment

fix #3030 and run relateive test in edge-runtime #3036

fix #3030 and run relateive test in edge-runtime #3036

Conversation

promer94 commented Nov 5, 2024 • edited Loading

codesandbox-ci bot commented Nov 5, 2024 • edited Loading

socket-security bot commented Nov 5, 2024 • edited Loading

huozhi left a comment

Choose a reason for hiding this comment

promer94 commented Nov 5, 2024 •

edited

Loading

codesandbox-ci bot commented Nov 5, 2024 •

edited

Loading

socket-security bot commented Nov 5, 2024 •

edited

Loading