Skip to content

Commit

Permalink
Merge branch 'main' into remove-dependecy
Browse files Browse the repository at this point in the history
  • Loading branch information
torresgol10 authored Nov 21, 2024
2 parents 52f6eef + 2895ae2 commit 0dc8c26
Show file tree
Hide file tree
Showing 691 changed files with 28,389 additions and 19,688 deletions.
4 changes: 2 additions & 2 deletions .github/.kodiak.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ notify_on_conflict = false
# Without this, only branches that are passing CI will get updated.
# The benefit of this config is that PRs that we want to automerge, but
# have failed because the test suite is flaky will get stuck, unless someone
# presses the Update Branch button manually, or re-triggers the Github workflow
# presses the Update Branch button manually, or re-triggers the GitHub workflow
# for tests again. This causes delays in getting easy PRs in.
always = true

Expand All @@ -28,7 +28,7 @@ always = true
# (i.e. PRs with the "pr: automerge" label, which is configured above).
# This label allows PR authors to keep their PR branch up-to-date without
# opting into Kodiak's automerge feature. This is useful if you want to use
# Github's AutoMerge feature instead.
# GitHub's AutoMerge feature instead.
autoupdate_label = "pr: autoupdate"

[merge.message]
Expand Down
60 changes: 20 additions & 40 deletions .github/ISSUE_TEMPLATE/0-turborepo-bug-report.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
name: Turborepo Bug Report
description: Create a bug report for the Turborepo core team
name: Turborepo bug report
description: Create a bug report
labels: ["kind: bug", "needs: triage"]
title: "🐛 Bug: "

body:
- type: markdown
attributes:
value: |
This template is to report Turborepo bugs. Before opening a new issue, please do a [search](https://github.com/vercel/turborepo/issues) of existing issues and :+1: upvote the existing issue instead. This will result in a quicker resolution.
This template is to report bugs. Before opening a new issue, please do a [search](https://github.com/vercel/turborepo/issues) of existing issues and :+1: upvote the existing issue instead. This will result in a quicker resolution.
If you need help with your own project, you can:
- Start a discussion in the ["Help" section](https://github.com/vercel/turborepo/discussions/categories/help).
Expand All @@ -23,34 +25,7 @@ body:
attributes:
label: Link to code that reproduces this issue
description: |
A link to a **public** GitHub repository with a minimal reproduction. Ideally, minimal reproductions should be created using [`npx create-turbo@canary -e with-shell-commands`](https://github.com/vercel/turborepo/tree/main/examples/with-shell-commands) and should include only changes that contribute to the issue. You may also use [`npx create-turbo@canary -e <example-name>`](https://github.com/vercel/turborepo/tree/main/examples) to create a reproduction that includes frameworks if you believe your bug requires a framework to reproduce.
validations:
required: true

- type: dropdown
id: packageManager
attributes:
multiple: true
label: What package manager are you using / does the bug impact?
description: |
You can quickly check different package managers in your reproduction using `npx turbo/workspaces convert`.
options:
- npm
- pnpm
- Yarn v1
- Yarn v2/v3/v4 (node_modules linker only)
validations:
required: true

- type: dropdown
id: os
attributes:
label: What operating system are you using?
options:
- Mac
- Windows
- Linux
- Other
A link to a **public** GitHub repository with a minimal reproduction. Ideally, minimal reproductions should be created using [`npx create-turbo@canary -e with-shell-commands`](https://github.com/vercel/turborepo/tree/main/examples/with-shell-commands) and should include only changes that contribute to the issue. You may also use [`npx create-turbo@canary -e <example-name>`](https://github.com/vercel/turborepo/tree/main/examples) to create a reproduction that includes frameworks if you believe your bug requires a specific framework to reproduce.
validations:
required: true

Expand All @@ -64,40 +39,45 @@ body:

- type: textarea
attributes:
label: Describe the Bug
label: Enviroment information
render: block
description: |
A clear and concise description of the bug.
Run the command `turbo info` and paste its output here. Please review it in case there is sensitive information you don't want to share.
- type: textarea
attributes:
label: Expected behavior
description: |
A clear and concise description of what you expected to happen.
validations:
required: true

- type: textarea
attributes:
label: Expected Behavior
label: Actual behavior
description: |
A clear and concise description of what you expected to happen.
A clear and concise description of the bug.
validations:
required: true

- type: textarea
attributes:
label: To Reproduce
description: |
Steps to reproduce the unexpected behavior. Please provide a clear code snippets that always reproduces the issue or a GitHub repository. Screenshots can be provided in the issue body below.
Steps to reproduce the unexpected behavior. Please provide clear code snippets that always reproduces the issue or a GitHub repository. Screenshots can be provided in "Additional context" below.
validations:
required: true

- type: markdown
attributes:
value: |
Another way you can help the maintainers is to pinpoint the `canary` version of `turbo` that introduced the issue. Check out our [releases](https://github.com/vercel/turborepo/releases), and try to find the first `canary` release that introduced the issue. This will help us narrow down the scope of the issue, and possibly point to the PR/code change that introduced it. You can install a specific version of `turbo` by running `npm install turbo@<version>`.
Another way you can help the maintainers is to pinpoint the `canary` version of `turbo` that introduced the issue. Check out our [releases](https://github.com/vercel/turborepo/releases), and try to find the first `canary` release that introduced the issue. While not required, this will help us narrow down the scope of the issue, and possibly point to the PR/code change that introduced it. You can install a specific version of `turbo` by running `npm install turbo@<version>`.
- type: textarea
attributes:
label: Additional context
description: |
Any extra information that might help us investigate. For example, where are you deploying your application (Vercel, Docker, other platform)? Is it only reproducible on that platform, or locally too? Is the issue only happening in a specific browser? etc.
placeholder: |
I tested my reproduction against different canary releases, and the first one that introduced the bug was "1.10.4-canary.2", since reverting to "1.10.4-canary.1" works.
I tested my reproduction against different canary releases, and the first one that introduced the bug was "2.2.4-canary.2", since reverting to "2.3.4-canary.1" works.
or
I am using GitHub Actions but running my tasks locally does not have the same issue.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/1-docs.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: "Documentation update or improvement"
description: A request to update or improve documentation
title: "Docs: "
title: "📚 Docs: "
labels:
- "template: documentation"
body:
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/cargo-sweep/action.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: "cargo-sweep"
description: "Runs cargo-sweep to clean old build artifacts"
runs:
using: "node16"
using: "node20"
main: "dist/main/index.js"
post: "dist/post/index.js"
2 changes: 1 addition & 1 deletion .github/actions/setup-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ runs:
uses: pnpm/action-setup@v4

- name: Setup Node.js
uses: actions/setup-node@v3.6.0
uses: actions/setup-node@v4
with:
node-version: ${{ inputs.node-version }}
cache: pnpm
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/setup-rust/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ runs:
- name: Set Up Protoc
id: set-up-protoc
continue-on-error: true
uses: arduino/setup-protoc@v2.1.0
uses: arduino/setup-protoc@v3
with:
version: "26.x"
repo-token: ${{ inputs.github-token }}

- name: Set Up Protoc (second try)
if: steps.set-up-protoc.outcome == 'failure'
uses: arduino/setup-protoc@v2.1.0
uses: arduino/setup-protoc@v3
with:
version: "26.x"
repo-token: ${{ inputs.github-token }}
Expand Down
11 changes: 1 addition & 10 deletions .github/turbo-orchestrator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,7 @@

labeler:
labels:
# owned-by
- label: "owned-by: turborepo"
when:
isAnyFileOwnedByMatch: '@vercel\/turbo-oss'

- label: "created-by: turborepo"
when:
isPRAuthorMatch: "^(anthonyshew|dimitropoulos|tknickman|chris-olszewski|NicholasLYang)$"

# needs: triage when not any of the turbopack or turborepo team
# needs: triage when not any of the turborepo team
- label: "needs: triage"
when:
isNotPRAuthorMatch: "^(padmaia|anthonyshew|dimitropoulos|tknickman|chris-olszewski|NicholasLYang)$"
Expand Down
1 change: 0 additions & 1 deletion .github/turborepo-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
changelog:
exclude:
labels:
- "owned-by: turbopack"
- "area: ci"
- "release: turborepo"
categories:
Expand Down
22 changes: 12 additions & 10 deletions .github/workflows/bench-turborepo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-node

- name: Setup Turborepo Environment
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
runner: windows-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set filename for profile
id: filename
shell: bash
Expand All @@ -87,9 +87,9 @@ jobs:
run: pnpm -F @turbo/benchmark ttft "${{ steps.filename.outputs.filename }}"

- name: Upload Artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: profiles # This name will be the folder each file gets downloaded to
name: profiles-${{ matrix.os.name }} # This name will be the folder each file gets downloaded to
if-no-files-found: error
# cwd is root of the repository, so we need the benchmark/ prefixed path
path: |
Expand All @@ -106,16 +106,17 @@ jobs:
TINYBIRD_TOKEN: ${{secrets.TINYBIRD_TOKEN}}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup Node
uses: ./.github/actions/setup-node

- name: Download profiles
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: profiles
path: packages/turbo-benchmark/profiles/
pattern: profiles-*
merge-multiple: true

- name: Display TTFT Data
shell: bash
Expand All @@ -140,16 +141,17 @@ jobs:
needs: [send-to-tinybird]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup Node
uses: ./.github/actions/setup-node

- name: Download profiles
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: profiles
path: packages/turbo-benchmark/profiles/
pattern: profiles-*
merge-multiple: true

- name: Display TTFT Data
shell: bash
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,14 @@ jobs:
validate-docs-links:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Checkout
uses: actions/checkout@v4

- name: "Setup Node"
uses: ./.github/actions/setup-node
- uses: ./.github/actions/setup-node
with:
node-version: 20

- name: "Run link checker"
- name: Run link checker
run: cd docs && pnpm run check-links
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
33 changes: 33 additions & 0 deletions .github/workflows/lint-pr-title.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Lint pull request title

on:
pull_request_target:
types:
- opened
- edited
- synchronize
- reopened

permissions:
pull-requests: read

jobs:
main:
name: Validate PR title
runs-on: ubuntu-latest
steps:
- uses: amannn/action-semantic-pull-request@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
# Configure that a scope must always be provided.
requireScope: false
# Configure additional validation for the subject based on a regex.
# Ensures that the subject doesn't start with an uppercase character.
subjectPattern: ^[A-Z].*$
# If `subjectPattern` is configured, you can use this property to override
# the default error message that is shown when the pattern doesn't match.
# The variables `subject` and `title` can be used within the message.
subjectPatternError: |
The subject "{subject}" found in the pull request title "{title}" doesn't match the configured pattern.
Please ensure that the subject doesn't start with a lowercase character.
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,9 @@ jobs:
uses: ./.github/actions/install-global-turbo

- name: Lint
# Manually set TURBO_API to an empty string to override Hetzner env
run: |
turbo run lint --env-mode=strict
TURBO_API= turbo run lint --env-mode=strict
cleanup:
name: Cleanup
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/lsp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
fail-fast: false
matrix:
settings:
- host: macos-12
- host: macos-13
target: "x86_64-apple-darwin"
container-options: "--rm"
- host: macos-12
- host: macos-13
target: "aarch64-apple-darwin"
container-options: "--rm"
- host: ubuntu-latest
Expand All @@ -45,14 +45,15 @@ jobs:
options: ${{ matrix.settings.container-options }}
steps:
- name: Checkout repo
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup Container
if: ${{ matrix.settings.container-setup }}
run: ${{ matrix.settings.container-setup }}

- name: Setup Protoc
uses: arduino/setup-protoc@v1.2.0
uses: arduino/setup-protoc@v3
with:
version: "26.x"
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Setup capnproto
Expand All @@ -73,7 +74,7 @@ jobs:
run: ${{ matrix.settings.rust-build-env }} cargo build --profile release-turborepo-lsp -p turborepo-lsp --target ${{ matrix.settings.target }}

- name: Upload Artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: turborepo-lsp-${{ matrix.settings.target }}
path: target/${{ matrix.settings.target }}/release-turborepo-lsp/turborepo-lsp*
Loading

0 comments on commit 0dc8c26

Please sign in to comment.