Skip to content

Commit

Permalink
Use the flag everywhere except where testing the env var
Browse files Browse the repository at this point in the history
  • Loading branch information
mehulkar committed Mar 31, 2023
1 parent 64307e5 commit 74375d0
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Setup
$ . ${TESTDIR}/../setup.sh $(pwd)
$ rm -rf .turbo/runs

$ ${TURBO} run build --summarize=true --filter=my-app
$ ${TURBO} run build --summarize --filter=my-app
\xe2\x80\xa2 Packages in scope: my-app (esc)
\xe2\x80\xa2 Running build in 1 packages (esc)
\xe2\x80\xa2 Remote caching disabled (esc)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Setup
# Delete all run summaries
$ rm -rf .turbo/runs

$ TURBO_RUN_SUMMARY=true ${TURBO} run build -- someargs > /dev/null # first run (should be cache miss)
$ ${TURBO} run build --summarize -- someargs > /dev/null # first run (should be cache miss)

# HACK: Generated run summaries are named with a ksuid, which is a time-sorted ID. This _generally_ works
# but we're seeing in this test that sometimes a summary file is not sorted (with /bin/ls) in the order we expect
Expand All @@ -17,7 +17,7 @@ Setup
# If you find this sleep statement, try running this test 10 times in a row. If there are no
# failures, it *should* be safe to remove.
$ sleep 1
$ TURBO_RUN_SUMMARY=true ${TURBO} run build -- someargs > /dev/null # run again (expecting full turbo here)
$ ${TURBO} run build --summarize -- someargs > /dev/null # run again (expecting full turbo here)

# no output, just check for 0 status code, which means the directory was created
$ test -d .turbo/runs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Setup

# Turbo exits early and doesn't generate run summaries on errors, so we need to use --continue for this test.
The maybefails task fails for one workspace but not the other
$ TURBO_RUN_SUMMARY=true ${TURBO} run maybefails --continue > /dev/null
$ ${TURBO} run --summarize maybefails --continue > /dev/null
my-app:maybefails: command finished with error, but continuing...
ERROR run failed: command exited (1)
[1]
Expand Down
2 changes: 1 addition & 1 deletion cli/integration_tests/single_package/run-summary.t
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Setup
$ . ${TESTDIR}/setup.sh $(pwd)

Check
$ ${TURBO} run build --summarize=true > /dev/null
$ ${TURBO} run build --summarize > /dev/null
$ test -d .turbo/runs
$ ls .turbo/runs/*.json | wc -l
\s*1 (re)
Expand Down

0 comments on commit 74375d0

Please sign in to comment.