Skip to content

Commit

Permalink
feat: add ability to spawn child process with pty (#7077)
Browse files Browse the repository at this point in the history
### Description

This PR adds, but doesn't hook up, the ability to spawn a child process
hooked up to a pseudo terminal.

I *highly* suggest reviewing each commit on its own. I tried my best to
split out prefactoring work from any feature work.

### Testing Instructions

Adapt unit tests to cover all of them. It will be noted that switching
to use a PTY does affect what programs output and so the tests were made
to not check for identical output, but just that we got the expected
output.
Closes TURBO-2128
  • Loading branch information
chris-olszewski authored Jan 25, 2024
1 parent 7414816 commit a1a2b6b
Show file tree
Hide file tree
Showing 5 changed files with 691 additions and 162 deletions.
146 changes: 139 additions & 7 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/turborepo-lib/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ notify = "5.1"
path-clean = "1.0.1"
petgraph = { workspace = true }
pidlock = { path = "../turborepo-pidlock" }
portable-pty = "0.8.1"
prost = "0.11.6"
rand = { workspace = true }
reqwest = { workspace = true, default-features = false, features = ["json"] }
Expand Down
Loading

1 comment on commit a1a2b6b

@vercel
Copy link

@vercel vercel bot commented on a1a2b6b Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.