-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: no longer include peer dependencies in transitive closures (#4824)
### Description Fixes #4757 Underlying issue was I was including `peerDependencies` in the dependency crawl. This resulted in an error since we expect to only be looking at external dependencies in the dependency crawl. ### Testing Instructions Added a failing unit test where there's a workspace that's used as a peer dependency that conflicts with a package in the registry.
- Loading branch information
1 parent
cfdefd5
commit e4c26b7
Showing
2 changed files
with
99 additions
and
1 deletion.
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
crates/turborepo-lockfiles/fixtures/workspace-peer-dependency.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
{ | ||
"name": "npm-test", | ||
"version": "1.0.0", | ||
"lockfileVersion": 2, | ||
"requires": true, | ||
"packages": { | ||
"": { | ||
"name": "npm-test", | ||
"version": "1.0.0", | ||
"license": "ISC", | ||
"workspaces": ["packages/**"] | ||
}, | ||
"node_modules/a": { | ||
"resolved": "packages/a", | ||
"link": true | ||
}, | ||
"node_modules/b": { | ||
"resolved": "packages/b", | ||
"link": true | ||
}, | ||
"node_modules/eslint": { | ||
"resolved": "packages/c", | ||
"link": true | ||
}, | ||
"node_modules/eslint-plugin-turbo": { | ||
"version": "1.9.3", | ||
"resolved": "https://registry.npmjs.org/eslint-plugin-turbo/-/eslint-plugin-turbo-1.9.3.tgz", | ||
"integrity": "sha512-ZsRtksdzk3v+z5/I/K4E50E4lfZ7oYmLX395gkrUMBz4/spJlYbr+GC8hP9oVNLj9s5Pvnm9rLv/zoj5PVYaVw==", | ||
"peerDependencies": { | ||
"eslint": ">6.6.0" | ||
} | ||
}, | ||
"packages/a": { | ||
"dependencies": { | ||
"eslint": "^0.0.0-workspace", | ||
"eslint-plugin-turbo": "^1.9.3" | ||
} | ||
}, | ||
"packages/b": { | ||
"peerDependencies": { | ||
"eslint": "*" | ||
} | ||
}, | ||
"packages/c": { | ||
"name": "eslint", | ||
"version": "0.0.0-workspace" | ||
} | ||
}, | ||
"dependencies": { | ||
"a": { | ||
"version": "file:packages/a", | ||
"requires": { | ||
"eslint": "^0.0.0-workspace", | ||
"eslint-plugin-turbo": "^1.9.3" | ||
} | ||
}, | ||
"b": { | ||
"version": "file:packages/b", | ||
"requires": {} | ||
}, | ||
"eslint": { | ||
"version": "file:packages/c" | ||
}, | ||
"eslint-plugin-turbo": { | ||
"version": "1.9.3", | ||
"resolved": "https://registry.npmjs.org/eslint-plugin-turbo/-/eslint-plugin-turbo-1.9.3.tgz", | ||
"integrity": "sha512-ZsRtksdzk3v+z5/I/K4E50E4lfZ7oYmLX395gkrUMBz4/spJlYbr+GC8hP9oVNLj9s5Pvnm9rLv/zoj5PVYaVw==", | ||
"requires": {} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters