Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version command throws SIGSEGV #1839

Closed
7flash opened this issue Sep 2, 2022 · 2 comments · Fixed by #1870
Closed

version command throws SIGSEGV #1839

7flash opened this issue Sep 2, 2022 · 2 comments · Fixed by #1870
Assignees

Comments

@7flash
Copy link
Contributor

7flash commented Sep 2, 2022

What version of Turborepo are you using?

1.4.4

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Linux

Describe the Bug

image

Expected Behavior

It's expected either show version in response / either show available commands / either show error message (as happens when calling other non-existing commands, but specifically version command throws segfault error)

To Reproduce

npx create-turbo

.devcontainer/Dockerfile

ARG VARIANT="18-bullseye"
FROM mcr.microsoft.com/vscode/devcontainers/typescript-node:0-${VARIANT}
@nathanhammond
Copy link
Contributor

This is indeed a bug, this is triggering a segfault:

scope.AddFlags(&opts.scopeOpts, flags)

@gsoltis
Copy link
Contributor

gsoltis commented Sep 6, 2022

The existing help text for turbo --help doesn't show a turbo version command. @7flash did you find that documented somewhere? AFAICT you want turbo --version. If somewhere else is showing turbo version, we ought to correct that.

We definitely shouldn't crash though, that's clearly a bug.

@kodiakhq kodiakhq bot closed this as completed in #1870 Sep 6, 2022
kodiakhq bot pushed a commit that referenced this issue Sep 6, 2022
We don't have a `turbo version` command, so don't special case it in argument parsing.

Fixes #1839 

This is superceded by #1792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants