-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --grouped
flag to group log output
#219
Comments
Could this be enabled selectively? For example, I may wish to only group the |
@jaredpalmer is this taken up? If not I'd love to take this up. Any guidance would be awesome |
Would love this. Our CI log is almost useless. |
+1 could really use this for test output |
* Implement test app generator * Implement basic test app generator * Remove into_iter() Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com> * Update crates/turbopack-create-test-app/src/main.rs Co-authored-by: Leah <github.leah@hrmny.sh> Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com> Co-authored-by: Leah <github.leah@hrmny.sh>
I'll try check this on the weekend |
We have the same problem in a bigger project (turbo.json n around 300 lines and 25 package.json in the mono repo). It's always a bit hard to find something in the log :-) This feature would be really helpful for us ❤️ |
It also would be cool, if in that case, an additional parameter would toggle turbo to output GitHub Workflow Group statements for every task.
Alternatively, turbo could check if it's run in a GitHub Workflow via existence of |
Couple naming options that have been floated internally:
The (cc @rafaeltab if you're interested in picking this up, let me know and I can help you get it merged. You can pick either of the names and we can change it once we get consensus here / internally) @robaca, we're interested in handling the Github log grouping you mentioned after prefixing and grouping options land independently. The idea would be to compose both to make it Just Work in Github. |
This adds a `--log-prefix=none` CLI argument to `turbo run` commands that will remove the `<package>:<task>: ` prefix when running tasks (both on execute and replay from cache). This removal will also apply to "single package" repos where the prefix is just `<task>: ` This new option is intended to alleviate some user issues piping logs into other tools, but comes with a Buyer Beware warning that logs from parallel tasks are still interleaved. We may implement a buffering mechanism (long time issue: #219), that will further help with this, but this PR does not do that.
How can i contribute to this issue I am just a begineer? |
@DivvSaxena Hey! I am working on this issue, and while not at a massive pace I am getting close to finishing it. If you still want to contribute to Turborepo, possibly through a different issue keep reading. If you join the discord, perhaps someone can point you to a different issue you could pick up. If you mention me there, I'll try to get you in contact with someone who could point you in the right direction. If you don't have discord or are unable to join the discord server for some other reason please let me know, and I'll try to get someone looking at this. |
This was merged in #3916, thanks @rafaeltab! |
Describe the feature you'd like to request
https://twitter.com/yangshunz/status/1470019087669489665
Describe the solution you'd like
--grouped
flag that will not stream, but buffer and print all logs of a task once in a single group after a task is completed. This should be the default log behavior in non-interactive terminal processes. Ourlogstreamer
abstraction already has an option for this, but need to make sure that prints to stdout/stderr are not intermingled. Ideally, writes should print First In, First Out, so a (new) queue/channel might be needed inside ofrun_state.go
.Describe alternatives you've considered
--buffered
flag nameThe text was updated successfully, but these errors were encountered: