-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[turborepo] turbo prune ignore local peerDependencies #4915
Comments
I am also being hit with this problem. I imagine this is due to the change in #4824 It seems that the lockfile generated by I've updated to pass the |
This won't fix the problem since peerDependencies are local |
You are right, my issue is not exactly the same as yours. I'm having trouble with missing peerDependencies from (I believe) jest
|
Same problem. 1.9.4 prune peer dependencies and when |
### Description In #4824 I removed the peer dependencies when collecting all dependencies for a package. This is correct behavior for npm3-6, but is overly strict for npm7+ as npm will automatically install peer dependencies if they aren't provided. This partially addresses #4915, but doesn't handle the case where a workspace has peer dependencies that the host package doesn't provide. I will address that, but that requires a much larger change to how we construct the workspace graph and extending our package manager interface. ### Testing Instructions Tests added in ##4824 still pass along with a new unit test that verifies we pick up peer dependencies --------- Co-authored-by: Chris Olszewski <Chris Olszewski>
Still relevant! |
Just faced this as well. Would be nice to have a fix! |
We're facing the same issue. |
This is still outstanding unfortunately. We recently got bit by this and only a workaround helped where:
Steps 2-3. contain our workaround to our monorepo of 100+ workspaces, that is only needed until the issue reported here is resolved. Without the workaround, step 5 would fail at the installation by npm erroring out on missing local peer definitions (and because the custom prefixed local package names are not on any remote registries) |
What version of Turborepo are you using?
1.9.4
What package manager are you using / does the bug impact?
npm
What operating system are you using?
Mac
Describe the Bug
turbo prune ignore local peer deps
Expected Behavior
turbo prune respects peerDependencies
To Reproduce
out will only be depend-on-tested
Reproduction Repo
https://github.com/Naymi/turbo-prune-ignore-peer-demo
The text was updated successfully, but these errors were encountered: