Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump versions of dependencies. (Go, pnpm, CI, .devcontainer) (#1153) #1168

Closed
wants to merge 3 commits into from
Closed

Revert "Bump versions of dependencies. (Go, pnpm, CI, .devcontainer) (#1153) #1168

wants to merge 3 commits into from

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented May 2, 2022

This reverts commit 054fd07.

Go version bump broke our linting :(

We should re-upgrade when golangci/golangci-lint#2649 is resolved

Revert "Bump versions of dependencies. (Go, pnpm, CI, .devcontainer) (#…
654fc6e 
…1153)"

This reverts commit 054fd07.

Go version bump broke our linting :(
@vercel
Copy link

vercel bot commented May 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview May 3, 2022 at 4:53PM (UTC)

nathanhammond
nathanhammond suggested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hold, I'd like to understand what problem you encountered?

@tknickman
Copy link
Member

Looks like this is no longer needed, closing as cleanup.

@tknickman tknickman closed this Jun 8, 2022
@gsoltis
Copy link
Contributor Author

gsoltis commented Jun 8, 2022

We may yet end up w/ go 1.17. The linters continue to be broken, and we continue to not have any generic code. I think at the very least we ought to add go: 1.17 to .golangci.yml if we don't want to downgrade the language version. Then we'll have a decision to make when someone wants to use generics.

@nathanhammond nathanhammond mentioned this pull request Jun 13, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 13, 2022
@nathanhammond
Run lint against Go 1.17 to constrain introduction of 1.18 features. (#…
fc02119 
…1374)

@gsoltis had a good minimally-invasive suggestion which gets our linters back working: #1168 (comment)

This PR implements that suggestion. We still build and publish with 1.18, the only real difference is we run lint against 1.17; which will happily break us if we introduce 1.18-specific features.
@ForsakenHarmony ForsakenHarmony deleted the gsoltis/revert_go_upgrade branch January 9, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanhammond nathanhammond nathanhammond requested changes

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer

@gaspar09 gaspar09 Awaiting requested review from gaspar09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsoltis @tknickman @nathanhammond @jaredpalmer