fix: mismatched pnpm lockfile version resolution #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
chris-olszewski
requested review from
tknickman
and removed request for
nathanhammond
arlyon
approved these changes
Feb 3, 2023
mehulkar
pushed a commit
that referenced
this pull request
Feb 3, 2023
Fixes #3564 I created a regression when adding support for pnpm `lockfileVersion: 6` that caused us to not include some indirect dependencies of a workspace. A package would be missing only if a workspace had a direct dependency on the package that was also included as an indirect dependency where the version ranges didn't overlap. See the new test fixture for a basic version of how this could occur. Huge thanks to @shawnmcknight for providing a reproduction!
chris-olszewski
added a commit
that referenced
this pull request
Feb 7, 2023
Fixes #3638 I added a regression in #3611 where we would error if there was a specifier mismatch and the specifier wasn't totally resolved. This was an unintended change to the previous behavior would indicate it didn't find a package resolution. Tested against [provided reproduction](https://github.com/sushiswap/sushiswap)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3564
I created a regression when adding support for pnpm
lockfileVersion: 6that caused us to not include some indirect dependencies of a workspace. A package would be missing only if a workspace had a direct dependency on the package that was also included as an indirect dependency where the version ranges didn't overlap. See the new test fixture for a basic version of how this could occur.Huge thanks to @shawnmcknight for providing a reproduction!