Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename experimental.resolveAlias to experimental.turbopackResolveAlias #3651

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

wbinnssmith
Copy link
Member

Following discussion at vercel/next.js#45560, this renames experimental.resolveAlias to experimental.turbopackResolveAlias to make it clear that this option is only available in Turbopack.

Test Plan: cargo test -p next-dev-tests

@wbinnssmith wbinnssmith requested a review from a team as a code owner February 6, 2023 16:45
@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-designsystem-docs 🔄 Building (Inspect) Feb 6, 2023 at 6:28PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 6:28PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:28PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:28PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:28PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:28PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:28PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:28PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:28PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:28PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@wbinnssmith
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Benchmark for e973a4f

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9368.95µs ± 85.62µs 9337.78µs ± 69.48µs -0.33%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9483.56µs ± 78.55µs 9587.57µs ± 98.35µs +1.10%
bench_hmr_to_commit/Turbopack RSC/1000 modules 493.34ms ± 1.32ms 491.62ms ± 1.27ms -0.35%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9435.80µs ± 75.93µs 9522.85µs ± 74.73µs +0.92%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8273.68µs ± 93.37µs 8333.85µs ± 53.69µs +0.73%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8435.49µs ± 64.54µs 8544.43µs ± 64.87µs +1.29%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8468.65µs ± 66.95µs 8519.86µs ± 98.67µs +0.60%
bench_hydration/Turbopack RCC/1000 modules 4195.10ms ± 7.83ms 4174.76ms ± 6.20ms -0.48%
bench_hydration/Turbopack RSC/1000 modules 3796.65ms ± 9.62ms 3825.01ms ± 20.87ms +0.75%
bench_hydration/Turbopack SSR/1000 modules 3717.01ms ± 7.58ms 3705.98ms ± 15.12ms -0.30%
bench_startup/Turbopack CSR/1000 modules 2767.76ms ± 8.77ms 2745.87ms ± 12.58ms -0.79%
bench_startup/Turbopack RCC/1000 modules 2542.33ms ± 5.18ms 2549.30ms ± 9.11ms +0.27%
bench_startup/Turbopack RSC/1000 modules 2447.29ms ± 7.29ms 2445.67ms ± 6.99ms -0.07%
bench_startup/Turbopack SSR/1000 modules 2104.62ms ± 2.76ms 2098.20ms ± 2.97ms -0.31%

@wbinnssmith
Copy link
Member Author

wbinnssmith commented Feb 6, 2023

❌ This merge job failed. This pull request was not merged
Stack job ID: Vhr7gfAd51YOfETer2Pi.
See details on graphite.dev

@wbinnssmith wbinnssmith merged commit 1bfa7c2 into main Feb 7, 2023
@wbinnssmith wbinnssmith deleted the wbinnssmith/turbopack-resolve-alias branch February 7, 2023 00:22
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
vercel/turborepo#3651)

Following discussion at #45560,
this renames `experimental.resolveAlias` to
`experimental.turbopackResolveAlias` to make it clear that this option
is only available in Turbopack.

Test Plan: `cargo test -p next-dev-tests`
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
vercel/turborepo#3651)

Following discussion at #45560,
this renames `experimental.resolveAlias` to
`experimental.turbopackResolveAlias` to make it clear that this option
is only available in Turbopack.

Test Plan: `cargo test -p next-dev-tests`
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
vercel/turborepo#3651)

Following discussion at #45560,
this renames `experimental.resolveAlias` to
`experimental.turbopackResolveAlias` to make it clear that this option
is only available in Turbopack.

Test Plan: `cargo test -p next-dev-tests`
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
vercel/turborepo#3651)

Following discussion at #45560,
this renames `experimental.resolveAlias` to
`experimental.turbopackResolveAlias` to make it clear that this option
is only available in Turbopack.

Test Plan: `cargo test -p next-dev-tests`
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
vercel/turborepo#3651)

Following discussion at #45560,
this renames `experimental.resolveAlias` to
`experimental.turbopackResolveAlias` to make it clear that this option
is only available in Turbopack.

Test Plan: `cargo test -p next-dev-tests`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants