Automatic babel-loader followup #3944

wbinnssmith · 2023-02-24T01:18:09Z

This:

Addresses feedback from Automatically apply babel-loader for apps with babel configs #3862
Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read.
- Adds ModuleRuleCondition::ResourceIsVirtualAsset to filter these

This: * Addresses feedback from #3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these

vercel · 2023-02-24T01:18:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-cra-web	🔄 Building (Inspect)			Feb 25, 2023 at 0:26AM (UTC)
turbo-site	🔄 Building (Inspect)	Visit Preview		Feb 25, 2023 at 0:26AM (UTC)

8 Ignored Deployments

Name	Status	Updated
examples-basic-web	⬜️ Ignored (Inspect)	Feb 25, 2023 at 0:26AM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)	Feb 25, 2023 at 0:26AM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Feb 25, 2023 at 0:26AM (UTC)
examples-native-web	⬜️ Ignored (Inspect)	Feb 25, 2023 at 0:26AM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)	Feb 25, 2023 at 0:26AM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)	Feb 25, 2023 at 0:26AM (UTC)
examples-tailwind-web	⬜️ Ignored (Inspect)	Feb 25, 2023 at 0:26AM (UTC)
examples-vite-web	⬜️ Ignored (Inspect)	Feb 25, 2023 at 0:26AM (UTC)

crates/turbopack/src/module_options/module_rule.rs

crates/next-core/src/babel.rs

github-actions · 2023-02-24T01:45:05Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-02-24T02:33:34Z

Benchmark for `b227440`

Test	Base	PR	%	Significant %
bench_startup/Turbopack RSC/1000 modules	2350.18ms ± 6.80ms	2395.03ms ± 12.50ms	+1.91%	+0.26%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	12.59ms ± 0.11ms	12.69ms ± 0.14ms	+0.82%
bench_hmr_to_commit/Turbopack RCC/1000 modules	15.69ms ± 0.26ms	15.81ms ± 0.24ms	+0.74%
bench_hmr_to_commit/Turbopack RSC/1000 modules	525.83ms ± 1.73ms	525.75ms ± 1.23ms	-0.02%
bench_hmr_to_commit/Turbopack SSR/1000 modules	12.53ms ± 0.10ms	12.56ms ± 0.10ms	+0.27%
bench_hmr_to_eval/Turbopack CSR/1000 modules	11.54ms ± 0.14ms	11.59ms ± 0.09ms	+0.39%
bench_hmr_to_eval/Turbopack RCC/1000 modules	15.50ms ± 0.92ms	14.02ms ± 0.17ms	-9.58%
bench_hmr_to_eval/Turbopack SSR/1000 modules	11.45ms ± 0.09ms	11.50ms ± 0.11ms	+0.41%
bench_hydration/Turbopack RCC/1000 modules	3946.37ms ± 12.64ms	3969.32ms ± 14.05ms	+0.58%
bench_hydration/Turbopack RSC/1000 modules	3583.31ms ± 9.56ms	3564.83ms ± 16.26ms	-0.52%
bench_hydration/Turbopack SSR/1000 modules	3472.49ms ± 17.88ms	3431.67ms ± 15.40ms	-1.18%
bench_startup/Turbopack CSR/1000 modules	2645.08ms ± 9.26ms	2628.73ms ± 4.23ms	-0.62%
bench_startup/Turbopack RCC/1000 modules	2414.85ms ± 11.61ms	2409.98ms ± 9.49ms	-0.20%
bench_startup/Turbopack RSC/1000 modules	2350.18ms ± 6.80ms	2395.03ms ± 12.50ms	+1.91%	+0.26%
bench_startup/Turbopack SSR/1000 modules	2115.54ms ± 3.23ms	2116.83ms ± 5.75ms	+0.06%

github-actions · 2023-02-24T21:01:20Z

Benchmark for `016aa50`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules	497.40ms ± 0.77ms	500.28ms ± 0.58ms	+0.58%	+0.03%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	11.27ms ± 0.08ms	11.26ms ± 0.11ms	-0.09%
bench_hmr_to_commit/Turbopack RCC/1000 modules	15.54ms ± 0.10ms	15.80ms ± 0.16ms	+1.61%
bench_hmr_to_commit/Turbopack RSC/1000 modules	497.40ms ± 0.77ms	500.28ms ± 0.58ms	+0.58%	+0.03%
bench_hmr_to_commit/Turbopack SSR/1000 modules	11.24ms ± 0.08ms	11.28ms ± 0.08ms	+0.40%
bench_hmr_to_eval/Turbopack CSR/1000 modules	10.24ms ± 0.11ms	10.10ms ± 0.10ms	-1.39%
bench_hmr_to_eval/Turbopack RCC/1000 modules	14.48ms ± 0.12ms	14.60ms ± 0.10ms	+0.82%
bench_hmr_to_eval/Turbopack SSR/1000 modules	10.18ms ± 0.10ms	10.08ms ± 0.11ms	-1.06%
bench_hydration/Turbopack RCC/1000 modules	3778.02ms ± 10.13ms	3779.87ms ± 7.37ms	+0.05%
bench_hydration/Turbopack RSC/1000 modules	3431.59ms ± 10.68ms	3443.48ms ± 11.50ms	+0.35%
bench_hydration/Turbopack SSR/1000 modules	3294.78ms ± 9.94ms	3280.58ms ± 7.37ms	-0.43%
bench_startup/Turbopack CSR/1000 modules	2524.86ms ± 9.62ms	2511.21ms ± 8.03ms	-0.54%
bench_startup/Turbopack RCC/1000 modules	2321.37ms ± 4.43ms	2327.09ms ± 8.55ms	+0.25%
bench_startup/Turbopack RSC/1000 modules	2258.98ms ± 8.62ms	2258.78ms ± 4.74ms	-0.01%
bench_startup/Turbopack SSR/1000 modules	2030.41ms ± 1.94ms	2031.47ms ± 2.87ms	+0.05%

crates/turbopack/src/module_options/rule_condition.rs

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

github-actions · 2023-02-25T01:39:13Z

Benchmark for `12e0673`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	11.43ms ± 0.06ms	11.43ms ± 0.11ms	+0.06%
bench_hmr_to_commit/Turbopack RCC/1000 modules	15.24ms ± 0.22ms	15.75ms ± 0.13ms	+3.37%
bench_hmr_to_commit/Turbopack RSC/1000 modules	503.50ms ± 1.84ms	502.57ms ± 1.20ms	-0.19%
bench_hmr_to_commit/Turbopack SSR/1000 modules	11.51ms ± 0.13ms	11.43ms ± 0.08ms	-0.70%
bench_hmr_to_eval/Turbopack CSR/1000 modules	10.51ms ± 0.14ms	10.48ms ± 0.12ms	-0.30%
bench_hmr_to_eval/Turbopack RCC/1000 modules	14.22ms ± 0.19ms	14.31ms ± 0.28ms	+0.68%
bench_hmr_to_eval/Turbopack SSR/1000 modules	10.53ms ± 0.08ms	10.38ms ± 0.07ms	-1.34%
bench_hydration/Turbopack RCC/1000 modules	3813.97ms ± 13.85ms	3813.37ms ± 7.03ms	-0.02%
bench_hydration/Turbopack RSC/1000 modules	3474.75ms ± 11.64ms	3450.91ms ± 12.96ms	-0.69%
bench_hydration/Turbopack SSR/1000 modules	3336.37ms ± 9.76ms	3341.47ms ± 13.97ms	+0.15%
bench_startup/Turbopack CSR/1000 modules	2556.77ms ± 6.04ms	2560.17ms ± 7.43ms	+0.13%
bench_startup/Turbopack RCC/1000 modules	2351.23ms ± 7.98ms	2351.91ms ± 6.45ms	+0.03%
bench_startup/Turbopack RSC/1000 modules	2293.74ms ± 10.84ms	2307.15ms ± 6.86ms	+0.58%
bench_startup/Turbopack SSR/1000 modules	2058.06ms ± 2.56ms	2059.65ms ± 3.56ms	+0.08%

# New Features - vercel/turborepo#3930 # Misc Changes - vercel/turborepo#3944 - vercel/turborepo#3774

This: * Addresses feedback from vercel/turborepo#3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

Automatic babel-loader followup

bc16fa4

This: * Addresses feedback from #3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these

wbinnssmith requested review from a team as code owners February 24, 2023 01:18

wbinnssmith requested review from mehulkar and tknickman February 24, 2023 01:18

turbo-orchestrator bot added team: turbopack labels Feb 24, 2023

wbinnssmith requested review from jridgewell and alexkirsz February 24, 2023 01:18

vercel bot deployed to Preview – turbo-site February 24, 2023 01:19 View deployment

jridgewell reviewed Feb 24, 2023

View reviewed changes

crates/turbopack/src/module_options/module_rule.rs Show resolved Hide resolved

crates/next-core/src/babel.rs Outdated Show resolved Hide resolved

fixup! Automatic babel-loader followup

0dc6929

mehulkar mentioned this pull request Feb 24, 2023

Remove ownership on Cargo.lock file #3953

Merged

mehulkar removed their request for review February 24, 2023 20:57

jridgewell approved these changes Feb 24, 2023

View reviewed changes

crates/turbopack/src/module_options/rule_condition.rs Outdated Show resolved Hide resolved

crates/turbopack/src/module_options/rule_condition.rs Outdated Show resolved Hide resolved

Merge branch 'main' into wbinnssmith/babel-loader-feedback

4e382be

turbo-orchestrator bot removed the team: turborepo label Feb 24, 2023

wbinnssmith and others added 2 commits February 24, 2023 15:47

Apply suggestions from code review

f354f7b

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

fixup! Automatic babel-loader followup

3e491bd

wbinnssmith merged commit fffcfa2 into main Feb 27, 2023

wbinnssmith deleted the wbinnssmith/babel-loader-feedback branch February 27, 2023 16:14

jridgewell mentioned this pull request Feb 28, 2023

build(cargo): update turbopack vercel/next.js#46581

Merged

ijjk pushed a commit to vercel/next.js that referenced this pull request Mar 1, 2023

build(cargo): update turbopack (#46581)

9b6ede2

# New Features - vercel/turborepo#3930 # Misc Changes - vercel/turborepo#3944 - vercel/turborepo#3774

DuCanhGH mentioned this pull request Mar 15, 2023

Fix(typedRoutes): fixed files from directories other than pages and app getting into Route vercel/next.js#47184

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatic babel-loader followup #3944

Automatic babel-loader followup #3944

wbinnssmith commented Feb 24, 2023

vercel bot commented Feb 24, 2023 •

edited

Loading

github-actions bot commented Feb 24, 2023 •

edited

Loading

github-actions bot commented Feb 24, 2023

github-actions bot commented Feb 24, 2023

github-actions bot commented Feb 25, 2023

Automatic babel-loader followup #3944

Automatic babel-loader followup #3944

Conversation

wbinnssmith commented Feb 24, 2023

vercel bot commented Feb 24, 2023 • edited Loading

github-actions bot commented Feb 24, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Feb 24, 2023

Benchmark for b227440

github-actions bot commented Feb 24, 2023

Benchmark for 016aa50

github-actions bot commented Feb 25, 2023

Benchmark for 12e0673

vercel bot commented Feb 24, 2023 •

edited

Loading

github-actions bot commented Feb 24, 2023 •

edited

Loading

Benchmark for `b227440`

Benchmark for `016aa50`

Benchmark for `12e0673`