fix next.js source map resolving #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
Benchmark for 7c95dbcClick to view benchmark
|
Benchmark for de72e6eClick to view benchmark
|
jridgewell
suggested changes
Mar 4, 2023
| @@ -81,7 +78,15 @@ impl ContentSource for NextSourceMapTraceContentSource { | |||
| self_vc.await?.asset_source, | |||
| NextSourceMapTraceContentProcessorVc::new(id, line, column, frame.name).into(), | |||
| ); | |||
| Ok(wrapped.as_content_source().get(path, Default::default())) | |||
| Ok(ContentSourceResultVc::exact( | |||
| ContentSourceContent::Rewrite( | |||
There was a problem hiding this comment.
I don't understand why these need to be rewrites. We're not expecting query params, right? We're not changing headers. This should be equivalent to just doing the .get() directly, right?
There was a problem hiding this comment.
We are changing the path, which is also reflected in the url in data.
sokra
added
the
pr: automerge
Benchmark for 44b8189
Click to view full benchmark
|
jridgewell
approved these changes
Mar 9, 2023
| @@ -27,6 +27,7 @@ turbopack-core = { workspace = true } | |||
| turbopack-dev-server = { workspace = true } | |||
| turbopack-ecmascript = { workspace = true } | |||
| url = { workspace = true } | |||
| urlencoding = { workspace = true } | |||
There was a problem hiding this comment.
Suggested change
| urlencoding = { workspace = true } |
| @@ -40,6 +42,17 @@ impl SourceMapContentSourceVc { | |||
| } | |||
| } | |||
|
|
|||
| fn encode_pathname_to_url(pathname: &str) -> String { | |||
There was a problem hiding this comment.
Can you add a comment on why we need to encode the pieces between /s?
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 9, 2023
# New Features - vercel/turborepo#3975 # Bug Fixes - vercel/turborepo#4129 - vercel/turborepo#4134 - vercel/turborepo#4062 # Performance - vercel/turborepo#4093
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Before the error overlay didn't show the source mapped file. Now it does. * The wrapped ContentSources need to wrap a Rewrite result. * Instead of returning a ContentSourceResult from a different ContentSource, one need to use Rewrite to get the data correct. ### Testing Instructions Throw an error in an next.js app that triggers the error overlay with stack trace.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Before the error overlay didn't show the source mapped file. Now it does. * The wrapped ContentSources need to wrap a Rewrite result. * Instead of returning a ContentSourceResult from a different ContentSource, one need to use Rewrite to get the data correct. ### Testing Instructions Throw an error in an next.js app that triggers the error overlay with stack trace.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Before the error overlay didn't show the source mapped file. Now it does. * The wrapped ContentSources need to wrap a Rewrite result. * Instead of returning a ContentSourceResult from a different ContentSource, one need to use Rewrite to get the data correct. ### Testing Instructions Throw an error in an next.js app that triggers the error overlay with stack trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before the error overlay didn't show the source mapped file.
Now it does.
Testing Instructions
Throw an error in an next.js app that triggers the error overlay with stack trace.