Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix assert alias #4114

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fix assert alias #4114

merged 1 commit into from
Mar 8, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 7, 2023

Description

typo, causing resolve failure

@sokra sokra requested a review from a team as a code owner March 7, 2023 21:44
@vercel
Copy link

vercel bot commented Mar 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 9:45PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 9:45PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 9:45PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 7, 2023 at 9:45PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 7, 2023 at 9:45PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 9:45PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 7, 2023 at 9:45PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 9:45PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 9:45PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 9:45PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Benchmark for ab6b4fe

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8924.78µs ± 46.65µs 9246.54µs ± 70.38µs +3.61% +0.97%
bench_startup/Turbopack RCC/1000 modules 2140.91ms ± 7.13ms 2109.90ms ± 4.16ms -1.45% -0.40%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8924.78µs ± 46.65µs 9246.54µs ± 70.38µs +3.61% +0.97%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.42ms ± 0.32ms 12.44ms ± 0.32ms -7.25%
bench_hmr_to_commit/Turbopack RSC/1000 modules 511.07ms ± 1.36ms 506.02ms ± 3.43ms -0.99%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9142.72µs ± 68.09µs 9109.95µs ± 58.71µs -0.36%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8200.48µs ± 93.27µs 8195.32µs ± 92.25µs -0.06%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.48ms ± 0.33ms 11.48ms ± 0.31ms -0.00%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8611.90µs ± 65.98µs 8648.05µs ± 39.59µs +0.42%
bench_hydration/Turbopack RCC/1000 modules 3657.56ms ± 7.77ms 3644.28ms ± 14.31ms -0.36%
bench_hydration/Turbopack RSC/1000 modules 3289.78ms ± 11.51ms 3254.98ms ± 14.58ms -1.06%
bench_hydration/Turbopack SSR/1000 modules 3364.02ms ± 10.86ms 3380.39ms ± 7.83ms +0.49%
bench_startup/Turbopack CSR/1000 modules 2669.99ms ± 7.86ms 2648.20ms ± 5.05ms -0.82%
bench_startup/Turbopack RCC/1000 modules 2140.91ms ± 7.13ms 2109.90ms ± 4.16ms -1.45% -0.40%
bench_startup/Turbopack RSC/1000 modules 2039.14ms ± 7.56ms 2038.19ms ± 5.38ms -0.05%
bench_startup/Turbopack SSR/1000 modules 2061.02ms ± 4.04ms 2062.91ms ± 4.19ms +0.09%

@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Mar 7, 2023
@kodiakhq kodiakhq bot merged commit ab6a92d into main Mar 8, 2023
@kodiakhq kodiakhq bot deleted the sokra/web-646-teamsteamsupportcases-error-resolving branch March 8, 2023 03:32
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
fix assert alias (vercel/turborepo#4114)
ac781ce 
### Description

typo, causing resolve failure
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
fix assert alias (vercel/turborepo#4114)
db5e2ea 
### Description

typo, causing resolve failure
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix assert alias (vercel/turborepo#4114)
b99083c 
### Description

typo, causing resolve failure
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix assert alias (vercel/turborepo#4114)
158bb91 
### Description

typo, causing resolve failure
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix assert alias (vercel/turborepo#4114)
44c14ce 
### Description

typo, causing resolve failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @jridgewell