Move Turborepo integration tests to their own workspace #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to use turbo to execute them
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
✅ This changes can build |
mehulkar
commented
Apr 18, 2023
| @@ -16,7 +16,8 @@ | |||
| "turbo-prebuilt": "node turbow.js", | |||
| "docs": "pnpm -- turbo run dev --filter=docs --no-cache", | |||
| "run-example": "./scripts/run-example.sh", | |||
| "prepare": "husky install" | |||
| "prepare": "husky install", | |||
| "test": "pnpm -- turbo run test" | |||
There was a problem hiding this comment.
Following the pattern, but if we had global turbo in Github CI, we wouldn't need to use pnpm -- turbo
| "extends": ["//"], | ||
| "pipeline": { | ||
| "test": { | ||
| "dependsOn": ["cli#build"], |
There was a problem hiding this comment.
This is here for completeness, but in the general case, we're building a local turbo before we run the test task, so turbo is already built. I can remove this if people have strong opinions.
Benchmark for f1443e1
Click to view full benchmark
|
|
tknickman
approved these changes
Apr 18, 2023
arlyon
approved these changes
Apr 18, 2023
|
Merging this as all relevant checkes have passed. The remaining checks are Turbopack Rust testing and Turbopack benchmarking, which are very slow and also unaffected by this PR. They are triggered because |
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
This enables us to remove the bespoke turbo task to run these tests, and also reduces our dependency on Makefile. Further, we can extract the helpers into their own workspace after this and use them for examples_tests so we can wire up dependencies even more accurately The Turbo Way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving into their own workspace so we can run them independently via Turbo (not Makefile), and potentially finding ways to test against examples, etc. Instead of:
Before:
After:
Alternatively: