Fix TSConfig extends pointing to node module #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
sokra
reviewed
May 2, 2023
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "extends": "tsconfig-mod/tsconfig.json" | |||
There was a problem hiding this comment.
I think the test case could be improve by also testing omitting the .json extension and naming the file different than tsconfig
Suggested change
| "extends": "tsconfig-mod/tsconfig.json" | |
| "extends": "tsconfig-mod/config" |
sokra
approved these changes
May 2, 2023
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
In #4754, I screwed up the resolution logic for configs that reference another config inside a node module. In it, I incorrectly joined `/tsconfig.json` before performing any lookup, because I thought the joining was happening in the `combinePaths` in https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/commandLineParser.ts#L3315. But, that combine has no real affect, it immediately gets stripped in a call to `getDirectoryPath` in https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/moduleNameResolver.ts#LL1703C93-L1703. Instead, it performs a basic `node_module` lookup using the input module name, and even tries to load the file referenced at that location (eg, it's a `extends: 'foo/tsconfig.json'`). If that fails, then it combines with an implied `/tsconfig` the same way a `/index` is appended when doing `require('./directory')`. Fixes WEB-974
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
In #4754, I screwed up the resolution logic for configs that reference another config inside a node module. In it, I incorrectly joined `/tsconfig.json` before performing any lookup, because I thought the joining was happening in the `combinePaths` in https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/commandLineParser.ts#L3315. But, that combine has no real affect, it immediately gets stripped in a call to `getDirectoryPath` in https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/moduleNameResolver.ts#LL1703C93-L1703. Instead, it performs a basic `node_module` lookup using the input module name, and even tries to load the file referenced at that location (eg, it's a `extends: 'foo/tsconfig.json'`). If that fails, then it combines with an implied `/tsconfig` the same way a `/index` is appended when doing `require('./directory')`. Fixes WEB-974
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
In #4754, I screwed up the resolution logic for configs that reference another config inside a node module. In it, I incorrectly joined `/tsconfig.json` before performing any lookup, because I thought the joining was happening in the `combinePaths` in https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/commandLineParser.ts#L3315. But, that combine has no real affect, it immediately gets stripped in a call to `getDirectoryPath` in https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/moduleNameResolver.ts#LL1703C93-L1703. Instead, it performs a basic `node_module` lookup using the input module name, and even tries to load the file referenced at that location (eg, it's a `extends: 'foo/tsconfig.json'`). If that fails, then it combines with an implied `/tsconfig` the same way a `/index` is appended when doing `require('./directory')`. Fixes WEB-974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4754, I screwed up the resolution logic for configs that reference another config inside a node module. In it, I incorrectly joined
/tsconfig.jsonbefore performing any lookup, because I thought the joining was happening in thecombinePathsin https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/commandLineParser.ts#L3315. But, that combine has no real affect, it immediately gets stripped in a call togetDirectoryPathin https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/moduleNameResolver.ts#LL1703C93-L1703.Instead, it performs a basic
node_modulelookup using the input module name, and even tries to load the file referenced at that location (eg, it's aextends: 'foo/tsconfig.json'). If that fails, then it combines with an implied/tsconfigthe same way a/indexis appended when doingrequire('./directory').Fixes WEB-974