Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update nextra #4792

Conversation

tknickman
Copy link
Member

Description

Needed to fix the missing copy code button on the docs, ended up updating Nextra and Next while I was in there.

Testing Instructions

Checkout the preview!

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 6:37pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 3, 2023 6:37pm
examples-cra-web ⬜️ Ignored (Inspect) May 3, 2023 6:37pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 3, 2023 6:37pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 3, 2023 6:37pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 3, 2023 6:37pm
examples-native-web ⬜️ Ignored (Inspect) May 3, 2023 6:37pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 3, 2023 6:37pm
examples-svelte-web ⬜️ Ignored (Inspect) May 3, 2023 6:37pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 3, 2023 6:37pm
examples-vite-web ⬜️ Ignored (Inspect) May 3, 2023 6:37pm

@@ -1,2 +1,2 @@
auto-install-peers = true
hoist = false
hoist-pattern[]=vfile-message
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rehype-katex was added to nextra in 2.0.2 to support LaTeX which brings in hast-util-from-html which has a dependency issue.

I sent them a PR here: syntax-tree/hast-util-from-html#4, but need to patch it on our end for now.

unstable_flexsearch: true,
unstable_staticImage: true,
themeConfig: "./theme.config.tsx",
defaultShowCopyCode: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this isn't set by default, have to check on that one (cc @shuding)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make that the default!

@@ -1,6 +1,5 @@
{
"*": {
"//": "Hide all the links from the sidebar or navbar, and disable ToC and Sidebar for these pages.",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New nextra isn't a fan of this key in meta (jsonc support wen)

* @type {import('nextra-theme-docs').DocsThemeConfig}
*/
const theme = {
const config: DocsThemeConfig = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank god we have real types here now!

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

🟢 CI successful 🟢

Thanks

@tknickman tknickman merged commit 75f908f into main May 3, 2023
@tknickman tknickman deleted the tomknickman/turbo-1071-turbobuild-is-missing-code-copy-button branch May 3, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants