More robust vdbg! macro #4995
Merged
More robust vdbg! macro #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
|
Linux Benchmark for c5e4b31Click to view benchmark
|
MacOS Benchmark for c5e4b31
Click to view full benchmark
|
ForsakenHarmony
approved these changes
May 17, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
May 23, 2023
### What? adds `NEXT_TURBOPACK_TRACING` env var to enable tracing. Writes into `.next/trace.log` There are 4 presets: * `NEXT_TURBOPACK_TRACING=overview` gives a overview of requests and modules processed. * `NEXT_TURBOPACK_TRACING=next` above plus details for next.js * `NEXT_TURBOPACK_TRACING=turbopack` above plus details for turbopack * `NEXT_TURBOPACK_TRACING=turbo-tasks` above plus details for turbo-tasks Published release builds will only allow `overview` to work, since all detailed instrumentation is statically disabled. see vercel/turborepo#4966 for more details ### Why? get more insight into build times ### Turbopack changes * vercel/turborepo#4995 * vercel/turborepo#5049 * vercel/turborepo#5053 * vercel/turborepo#4966
alexkirsz
pushed a commit
that referenced
this pull request
May 31, 2023
### Description Two small fixes: - The `vdbg!(vc; depth = 1)` macro would error out - the expanded `__init` syntax wasn't updated in #4995 - The JSON error message could panic if the line and/or column was `0` - This comes up when trying to deserialize into a struct with a missing prop, because it errors at the opening `{` brace ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
### What? adds `NEXT_TURBOPACK_TRACING` env var to enable tracing. Writes into `.next/trace.log` There are 4 presets: * `NEXT_TURBOPACK_TRACING=overview` gives a overview of requests and modules processed. * `NEXT_TURBOPACK_TRACING=next` above plus details for next.js * `NEXT_TURBOPACK_TRACING=turbopack` above plus details for turbopack * `NEXT_TURBOPACK_TRACING=turbo-tasks` above plus details for turbo-tasks Published release builds will only allow `overview` to work, since all detailed instrumentation is statically disabled. see vercel/turborepo#4966 for more details ### Why? get more insight into build times ### Turbopack changes * vercel/turborepo#4995 * vercel/turborepo#5049 * vercel/turborepo#5053 * vercel/turborepo#4966
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description I ran into a couple of issues with the vdbg! macro: * The macro tries to move its parameters within an async block, which requires everything that's moved to be both `Copy` and `'static` to work properly. This would break when trying to pass `&obj.property`, where the reference doesn't have a `'static` lifetime. Instead, I'm adding the requirement on parameters to impl `ToOwned` so we can ensure the `'static` lifetime, and creating an owned version of the parameter to move into the future. * The `CELL_COUNTERS` thread local could be unset when calling `.value_debug_format().try_to_string()`, which would panic the thread.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Two small fixes: - The `vdbg!(vc; depth = 1)` macro would error out - the expanded `__init` syntax wasn't updated in vercel/turborepo#4995 - The JSON error message could panic if the line and/or column was `0` - This comes up when trying to deserialize into a struct with a missing prop, because it errors at the opening `{` brace ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description I ran into a couple of issues with the vdbg! macro: * The macro tries to move its parameters within an async block, which requires everything that's moved to be both `Copy` and `'static` to work properly. This would break when trying to pass `&obj.property`, where the reference doesn't have a `'static` lifetime. Instead, I'm adding the requirement on parameters to impl `ToOwned` so we can ensure the `'static` lifetime, and creating an owned version of the parameter to move into the future. * The `CELL_COUNTERS` thread local could be unset when calling `.value_debug_format().try_to_string()`, which would panic the thread.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Two small fixes: - The `vdbg!(vc; depth = 1)` macro would error out - the expanded `__init` syntax wasn't updated in vercel/turborepo#4995 - The JSON error message could panic if the line and/or column was `0` - This comes up when trying to deserialize into a struct with a missing prop, because it errors at the opening `{` brace ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description I ran into a couple of issues with the vdbg! macro: * The macro tries to move its parameters within an async block, which requires everything that's moved to be both `Copy` and `'static` to work properly. This would break when trying to pass `&obj.property`, where the reference doesn't have a `'static` lifetime. Instead, I'm adding the requirement on parameters to impl `ToOwned` so we can ensure the `'static` lifetime, and creating an owned version of the parameter to move into the future. * The `CELL_COUNTERS` thread local could be unset when calling `.value_debug_format().try_to_string()`, which would panic the thread.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Two small fixes: - The `vdbg!(vc; depth = 1)` macro would error out - the expanded `__init` syntax wasn't updated in vercel/turborepo#4995 - The JSON error message could panic if the line and/or column was `0` - This comes up when trying to deserialize into a struct with a missing prop, because it errors at the opening `{` brace ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into a couple of issues with the vdbg! macro:
Copyand'staticto work properly. This would break when trying to pass&obj.property, where the reference doesn't have a'staticlifetime. Instead, I'm adding the requirement on parameters to implToOwnedso we can ensure the'staticlifetime, and creating an owned version of the parameter to move into the future.CELL_COUNTERSthread local could be unset when calling.value_debug_format().try_to_string(), which would panic the thread.