Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Update turbo.build to use Node 18 #5030

Merged
merged 1 commit into from
Jun 15, 2023
Merged

chore(docs): Update turbo.build to use Node 18 #5030

merged 1 commit into from
Jun 15, 2023

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented May 19, 2023 •
edited
Loading

@turbo-orchestrator turbo-orchestrator bot added area: ci area: docs Improvements or additions to documentation area: examples Improvements or additions to examples area: site team: turbopack labels May 19, 2023
@vercel
Copy link

vercel bot commented May 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 0:41am
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 0:41am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 0:41am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 0:41am
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 0:41am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 0:41am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 0:41am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 0:41am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 0:41am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 0:41am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2023 0:41am

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023 •
edited
Loading

⚠️ This change may fail to build next-swc.

Logs 

error: none of the selected packages contains these features: __internal_nextjs_integration_test

See job summary for details

@mehulkar mehulkar marked this pull request as ready for review May 19, 2023 06:42
@mehulkar mehulkar requested review from a team and anthonyshew as code owners May 19, 2023 06:42
@github-actions
Copy link
Contributor

Linux Benchmark for fe9e68e

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8341.35µs ± 40.69µs 8272.54µs ± 32.78µs -0.82%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7502.11µs ± 84.93µs 7523.59µs ± 112.91µs +0.29%
bench_startup/Turbopack CSR/1000 modules 882.86ms ± 1.99ms 885.08ms ± 2.69ms +0.25%

@github-actions
Copy link
Contributor

MacOS Benchmark for fe9e68e

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.99ms ± 0.13ms 27.42ms ± 0.08ms +1.61% +0.09%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.99ms ± 0.13ms 27.42ms ± 0.08ms +1.61% +0.09%
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.13ms ± 0.11ms 26.31ms ± 0.07ms +0.72%
bench_startup/Turbopack CSR/1000 modules 2702.06ms ± 31.15ms 2755.23ms ± 47.67ms +1.97%

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

tknickman
tknickman approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good - 👍🏼

Skimmed https://nodejs.org/en/blog/release/v18.0.0 and didn't notice anything too glaring as far as breaking changes go

@mehulkar mehulkar force-pushed the mehulkar/turbo-559-bump-turbobuild-in-vercel-to-node-18 branch from e3ff95f to b7d5176 Compare May 20, 2023 00:00
@github-actions
Copy link
Contributor

Linux Benchmark for ca22dfe

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 4593.47µs ± 41.73µs 4595.72µs ± 28.33µs +0.05%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4275.27µs ± 33.90µs 4438.11µs ± 198.02µs +3.81%
bench_startup/Turbopack CSR/1000 modules 706.00ms ± 1.57ms 702.47ms ± 4.03ms -0.50%

@github-actions
Copy link
Contributor

MacOS Benchmark for ca22dfe

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 9105.65ms ± 1487.63ms 2841.15ms ± 59.20ms -68.80% -51.72%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.07ms ± 0.26ms 26.78ms ± 0.30ms -1.05%
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.15ms ± 0.70ms 24.47ms ± 0.29ms +1.34%
bench_startup/Turbopack CSR/1000 modules 9105.65ms ± 1487.63ms 2841.15ms ± 59.20ms -68.80% -51.72%

@mehulkar mehulkar force-pushed the mehulkar/turbo-559-bump-turbobuild-in-vercel-to-node-18 branch from b7d5176 to f8f7158 Compare May 22, 2023 17:19
@github-actions
Copy link
Contributor

Linux Benchmark for 93ba0cf

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 4639.77µs ± 30.88µs 4681.73µs ± 32.50µs +0.90%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4320.94µs ± 24.02µs 4403.37µs ± 131.14µs +1.91%
bench_startup/Turbopack CSR/1000 modules 712.51ms ± 1.91ms 709.31ms ± 2.31ms -0.45%

@github-actions
Copy link
Contributor

MacOS Benchmark for 93ba0cf

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.92ms ± 0.94ms 25.86ms ± 0.36ms +17.98% +5.60%
bench_startup/Turbopack CSR/1000 modules 10.00s ± 2.34s 2718.80ms ± 62.62ms -72.82% -46.63%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.59ms ± 0.15ms 26.56ms ± 0.21ms -0.11%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.92ms ± 0.94ms 25.86ms ± 0.36ms +17.98% +5.60%
bench_startup/Turbopack CSR/1000 modules 10.00s ± 2.34s 2718.80ms ± 62.62ms -72.82% -46.63%

@mehulkar mehulkar mentioned this pull request Jun 8, 2023
Merged
@mehulkar mehulkar force-pushed the mehulkar/turbo-559-bump-turbobuild-in-vercel-to-node-18 branch from f8f7158 to 4952d0c Compare June 15, 2023 00:39
@turbo-orchestrator turbo-orchestrator bot removed area: docs Improvements or additions to documentation area: examples Improvements or additions to examples area: ci labels Jun 15, 2023
@mehulkar mehulkar enabled auto-merge (squash) June 15, 2023 00:41
@mehulkar mehulkar changed the title Update to Node 18 chore(docs): Update turbo.build to use Node 18 Jun 15, 2023
@mehulkar mehulkar mentioned this pull request Jun 15, 2023
Merged
@github-actions
Copy link
Contributor

Linux Benchmark for 7c6c3e4

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 4958.21µs ± 32.52µs 4946.75µs ± 27.17µs -0.23%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4577.49µs ± 29.24µs 4626.62µs ± 36.84µs +1.07%
bench_startup/Turbopack CSR/1000 modules 748.76ms ± 1.28ms 747.03ms ± 1.14ms -0.23%

@mehulkar mehulkar merged commit 8cdcb03 into main Jun 15, 2023
@mehulkar mehulkar deleted the mehulkar/turbo-559-bump-turbobuild-in-vercel-to-node-18 branch June 15, 2023 01:21
@mehulkar mehulkar mentioned this pull request Jun 15, 2023
Merged
mehulkar added a commit that referenced this pull request Jun 15, 2023
@mehulkar
chore(docs): Update to docs build to node 18 (#5030)
93952b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman tknickman approved these changes

@anthonyshew anthonyshew anthonyshew approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehulkar @tknickman @anthonyshew