Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel ignores concurrency and dependencies, we don't need to validate #5191

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Parallel ignores concurrency and dependencies, we don't need to validate #5191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cli/internal/run/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,13 @@ func buildTaskGraphEngine(
return nil, fmt.Errorf("Invalid task dependency graph:\n%v", err)
}

// Check that no tasks would be blocked by a persistent task
if err := engine.ValidatePersistentDependencies(g, rs.Opts.runOpts.Concurrency); err != nil {
return nil, fmt.Errorf("Invalid persistent task configuration:\n%v", err)
// Check that no tasks would be blocked by a persistent task. Note that the
// parallel flag ignores both concurrency and dependencies, so in that scenario
// we don't need to validate.
if !rs.Opts.runOpts.Parallel {
if err := engine.ValidatePersistentDependencies(g, rs.Opts.runOpts.Concurrency); err != nil {
return nil, fmt.Errorf("Invalid persistent task configuration:\n%v", err)
}
}

return engine, nil
Expand Down