ci(examples): update examples tests to diff full output #5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
mehulkar
commented
Jun 8, 2023
| \xe2\x80\xa2 Remote caching disabled (esc) | ||
|
|
||
| Tasks: 5 successful, 5 total | ||
| Cached: 3 cached, 5 total |
There was a problem hiding this comment.
Not going to try to fix it here, but it's weird that the gatsby example doesn't get full turbo on the second run. might be expected
There was a problem hiding this comment.
(This test isn't even running in CI, because this combo isn't part of the matrix)
mehulkar
force-pushed
the
mehulkar/turbo-1152-examples-tests-should-validate-output
branch
from
24da09a
to
c3f7031
Compare
mehulkar
force-pushed
the
mehulkar/turbo-1149-examples-tests-failing-on-main
branch
from
53c6644
to
4bfd3c4
Compare
mehulkar
force-pushed
the
mehulkar/turbo-1152-examples-tests-should-validate-output
branch
from
c3f7031
to
99f5ce4
Compare
mehulkar
changed the title
|
|
✅ This change can build |
Linux Benchmark for b5490c2Click to view benchmark
|
mehulkar
requested review from
tknickman and
chris-olszewski
and removed request for
a team
Linux Benchmark for 1c5696dClick to view benchmark
|
Linux Benchmark for 2325bdbClick to view benchmark
|
MacOS Benchmark for 2325bdb
Click to view full benchmark
|
Linux Benchmark for 8afb85aClick to view benchmark
|
Base automatically changed from
mehulkar/turbo-1149-examples-tests-failing-on-main
to
main
June 8, 2023 15:02
MacOS Benchmark for 8afb85a
Click to view full benchmark
|
This will help debug examples tests when they fail. - Switch env vars to CLI flags so they don't leak through to the turbo invocations in the actual test and change the output that we are not asserting against. - Enable corepack inside the test and then disable it again at the ened of the test.
mehulkar
force-pushed
the
mehulkar/turbo-1152-examples-tests-should-validate-output
branch
from
49a2dc8
to
2f1d036
Compare
Linux Benchmark for d15000dClick to view benchmark
|
gsoltis
approved these changes
Jun 8, 2023
|
The JS packages workflow is failing because the |
mehulkar
deleted the
mehulkar/turbo-1152-examples-tests-should-validate-output
branch
Windows Benchmark for d15000d
Click to view full benchmark
|
MacOS Benchmark for d15000d
Click to view full benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help debug examples tests when they fail.
(This is lifted from #5011)
Approve and merge #5240 first!