Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): group logging in github by task id #5318

Closed
wants to merge 1 commit into from
Closed

feat(logging): group logging in github by task id #5318

wants to merge 1 commit into from

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Jun 15, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Jun 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 6:38am
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 6:38am
turbo-site 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 6:38am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 6:38am
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 6:38am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 6:38am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 6:38am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 6:38am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 6:38am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 6:38am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 6:38am

@mehulkar mehulkar mentioned this pull request Jun 15, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turborepo e2e tests
  • Go integration tests

See workflow summary for details

@github-actions

This comment was marked as off-topic.

Sign in to view
@mehulkar mehulkar force-pushed the mehulkar/turbo-737-use-github-log-line-grouping-when-running-in-actions branch from afaf809 to 664df8c Compare June 15, 2023 23:17
@github-actions

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as off-topic.

Sign in to view
@mehulkar mehulkar mentioned this pull request Jun 16, 2023
Merged
@mehulkar mehulkar force-pushed the mehulkar/turbo-737-use-github-log-line-grouping-when-running-in-actions branch from eacc2fa to 5ef35c9 Compare June 16, 2023 22:17
@github-actions

This comment was marked as off-topic.

Sign in to view
@mehulkar mehulkar force-pushed the mehulkar/turbo-737-use-github-log-line-grouping-when-running-in-actions branch 2 times, most recently from 73813ac to 33b87cf Compare June 17, 2023 07:31
@mehulkar mehulkar changed the base branch from main to mk/fix-error-on-no-cmd June 17, 2023 07:32
@mehulkar mehulkar mentioned this pull request Jun 17, 2023
Merged
@mehulkar
Copy link
Contributor Author

The e2e windows tests are failing because it can't find the turbo binary. I want to say this is an issue because cli#build is getting a cache hit and the restore isn't working as expected on windows?

@weyert
Copy link
Contributor

weyert commented Jun 17, 2023

Similar functionality exists for other popular CI solution Teamcity:
https://www.jetbrains.com/help/teamcity/9.0/build-script-interaction-with-teamcity.html

e.g. ##teamcity[blockOpened name='<blockName>' description='<this is the description of blockName>']

Another popular CI solution that supports something similar Gitlab:
https://docs.gitlab.com/ee/ci/jobs/#custom-collapsible-sections

Base automatically changed from mk/fix-error-on-no-cmd to main June 20, 2023 06:09
@mehulkar
Copy link
Contributor Author

@weyert thanks for the note! do you mind making new issues for these if you're interested in adding support? I am on leave for a few weeks, so this PR will likely just add Github support. (You're also welcome to make a PR if you like, of course!)

@mehulkar mehulkar force-pushed the mehulkar/turbo-737-use-github-log-line-grouping-when-running-in-actions branch from 3761626 to dc702db Compare June 20, 2023 06:38
@mehulkar mehulkar mentioned this pull request Jun 20, 2023
Closed
mehulkar
mehulkar commented Jun 20, 2023
View reviewed changes
turborepo-tests/integration/test.sh
# so we can prevent the `GITHUB_ACTIONS` env var from being passed down here from the top level turbo.
# But as of now, this breaks our tests (and I'm not sure why). If we make that work, we can remove this
# explicit locking of log order. See PR attempt here: https://github.com/vercel/turbo/pull/5324
export TURBO_LOG_ORDER=stream
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes our integration tests (turbo_help.t and no_args.t, and verbosity.t), because when clap serializes the help message from the CLI, it inlines the value of this env var. So the output diff is:

-        --log-order <LOG_ORDER>          Set type of task output order. Use "stream" to show output as soon as it is available. Use "grouped" to show output when a command has finished execution. Use "auto" to let turbo decide based on its own heuristics. (default auto) [env: TURBO_LOG_ORDER=] [default: auto] [possible values: auto, stream, grouped]
+        --log-order <LOG_ORDER>          Set type of task output order. Use "stream" to show output as soon as it is available. Use "grouped" to show output when a command has finished execution. Use "auto" to let turbo decide based on its own heuristics. (default auto) [env: TURBO_LOG_ORDER=stream] [default: auto] [possible values: auto, stream, grouped]

We could solve this in a few ways:

@gsoltis gsoltis self-assigned this Jun 21, 2023
@gsoltis
Copy link
Contributor

gsoltis commented Jun 27, 2023

Closing in favor of #5385

@gsoltis gsoltis closed this Jun 27, 2023
@mehulkar mehulkar deleted the mehulkar/turbo-737-use-github-log-line-grouping-when-running-in-actions branch June 30, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gsoltis gsoltis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehulkar @weyert @gsoltis