Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): add "auto" options for log prefixing and ordering #5320

Merged
merged 3 commits into from
Jun 16, 2023
Merged

feat(logging): add "auto" options for log prefixing and ordering #5320

merged 3 commits into from
Jun 16, 2023

Commits on Jun 16, 2023

  1. feat(logging): add --log-order=auto 

    We need a default value for this that is different from stream, so that
we can set it based on environment clues and know that the user didn't explicitly
ask for streaming logs
    @mehulkar
    mehulkar committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    01e8238 View commit details
    Browse the repository at this point in the history

  2. feat(logging): add --log-prefix "task" and "auto" options 

    The default log prefixing today is "task". Adding an auto opttion and
making it the default gives us the liberty to change the prefixes
depending on context and based on our own heuristics.
    @mehulkar
    mehulkar committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c15836f View commit details
    Browse the repository at this point in the history

  3. update cli flag docs and test output

    @mehulkar
    mehulkar committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c451cb9 View commit details
    Browse the repository at this point in the history