Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turborepo): Handle empty workspace tasks #5365

Closed
wants to merge 1 commit into from

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Jun 22, 2023

Description

  • Don't crash if the given workspace doesn't have any tasks defined in its own turbo.json

Testing Instructions

  • Verified manually on the pnpm kitchen-sink example. This is a step on the path to getting the examples running properly, which will in turn then validate this change in an ongoing fashion

@gsoltis gsoltis requested a review from a team as a code owner June 22, 2023 20:44
@turbo-orchestrator turbo-orchestrator bot added pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo team: turborepo labels Jun 22, 2023
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview Jun 22, 2023 8:44pm
10 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm
examples-cra-web ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm
examples-native-web ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm
examples-svelte-web ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm
examples-vite-web ⬜️ Ignored (Inspect) Jun 22, 2023 8:44pm

@gsoltis gsoltis enabled auto-merge (squash) June 22, 2023 20:53
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Formatting

See workflow summary for details

@gsoltis
Copy link
Contributor Author

gsoltis commented Jun 23, 2023

Closing in favor of #5370

@gsoltis gsoltis closed this Jun 23, 2023
auto-merge was automatically disabled June 23, 2023 15:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants