turbopack-cli: modularize code to support turbopack build #5487

wbinnssmith · 2023-07-10T20:06:41Z

This work prepares for turbopack build by extracting code common between dev and build, such as asset context.

This also makes the cli accept a variadic list of entries rather than an unnamed directory parameter. The project directory is now available under --dir or -d.

Test Plan: cargo run -p turbopack-cli dev with a src/index.js present and cargo run -p turbopack-cli dev src/entry.js with src/entry.js present.

This work prepares for `turbopack build` by extracting code common between dev and build, such as asset context. This also makes the cli accept a variadic list of entries rather than an unnamed directory parameter. The project directory is now available under `--dir` or `-d`. Test Plan: `cargo run -p turbopack-cli dev` with a `src/index.js` present and `cargo run -p turbopack-cli dev src/entry.js` with `src/entry.js` present.

vercel · 2023-07-10T20:06:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-basic-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 20, 2023 8:43pm
examples-cra-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 20, 2023 8:43pm
examples-native-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 20, 2023 8:43pm

8 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 8:43pm
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 8:43pm
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 8:43pm
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 8:43pm
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 8:43pm
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 8:43pm
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 8:43pm
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 8:43pm

Depends on #5487 This implements a basic version of `turbopack build`, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node. Test Plan: `cargo run -p turbopack-cli build` with a `src/index.js` present and `cargo run -p turbopack-cli build src/entry.js` with `src/entry.js` present.

…e-cli

github-actions · 2023-07-10T21:10:08Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-07-10T21:11:00Z

✅ This change can build next-swc

github-actions · 2023-07-10T21:47:52Z

Linux Benchmark for cdf562d

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5385.02µs ± 34.07µs	5483.17µs ± 79.37µs	+1.82%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5034.84µs ± 19.79µs	5214.70µs ± 162.36µs	+3.57%
bench_startup/Turbopack CSR/1000 modules	801.98ms ± 0.64ms	803.81ms ± 1.29ms	+0.23%

arlyon

approving on behalf of repo

…e-cli

…dularize-cli

github-actions · 2023-07-18T17:42:32Z

Linux Benchmark for `3faad6f`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5626.48µs ± 38.57µs	5549.25µs ± 43.00µs	-1.37%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5173.96µs ± 16.65µs	5199.77µs ± 43.09µs	+0.50%
bench_startup/Turbopack CSR/1000 modules	816.97ms ± 1.31ms	821.68ms ± 2.94ms	+0.58%

…mith/modularize-cli

…e-cli

…dularize-cli

github-actions · 2023-07-19T18:04:40Z

Linux Benchmark for `d717989`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5387.73µs ± 30.42µs	5372.93µs ± 46.48µs	-0.27%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5036.53µs ± 21.99µs	5189.19µs ± 139.22µs	+3.03%
bench_startup/Turbopack CSR/1000 modules	797.31ms ± 1.03ms	800.36ms ± 3.43ms	+0.38%

github-actions · 2023-07-19T18:41:51Z

MacOS Benchmark for `d717989`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	29.04ms ± 0.16ms	28.29ms ± 0.18ms	-2.59%	-0.24%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	29.04ms ± 0.16ms	28.29ms ± 0.18ms	-2.59%	-0.24%
bench_hmr_to_eval/Turbopack CSR/1000 modules	28.28ms ± 0.22ms	27.56ms ± 0.18ms	-2.53%
bench_startup/Turbopack CSR/1000 modules	3354.60ms ± 36.20ms	3354.94ms ± 85.07ms	+0.01%

…mith/modularize-cli

github-actions · 2023-07-20T20:56:20Z

Linux Benchmark for `17be234`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	5456.67µs ± 14.59µs	N/A	N/A	N/A
bench_hmr_to_eval/Turbopack CSR/1000 modules	5161.98µs ± 91.61µs	N/A	N/A	N/A
bench_startup/Turbopack CSR/1000 modules	816.56ms ± 3.46ms	N/A	N/A	N/A

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	5456.67µs ± 14.59µs	N/A	N/A	N/A
bench_hmr_to_eval/Turbopack CSR/1000 modules	5161.98µs ± 91.61µs	N/A	N/A	N/A
bench_startup/Turbopack CSR/1000 modules	816.56ms ± 3.46ms	N/A	N/A	N/A

github-actions · 2023-07-20T21:23:27Z

MacOS Benchmark for `17be234`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	28.07ms ± 0.41ms	N/A	N/A	N/A
bench_hmr_to_eval/Turbopack CSR/1000 modules	27.36ms ± 0.94ms	N/A	N/A	N/A
bench_startup/Turbopack CSR/1000 modules	6623.41ms ± 964.15ms	N/A	N/A	N/A

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	28.07ms ± 0.41ms	N/A	N/A	N/A
bench_hmr_to_eval/Turbopack CSR/1000 modules	27.36ms ± 0.94ms	N/A	N/A	N/A
bench_startup/Turbopack CSR/1000 modules	6623.41ms ± 964.15ms	N/A	N/A	N/A

github-actions · 2023-07-20T21:25:19Z

Windows Benchmark for `17be234`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	15.48ms ± 0.05ms	N/A	N/A	N/A
bench_hmr_to_eval/Turbopack CSR/1000 modules	15.48ms ± 0.02ms	N/A	N/A	N/A
bench_startup/Turbopack CSR/1000 modules	2943.12ms ± 18.36ms	N/A	N/A	N/A

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	15.48ms ± 0.05ms	N/A	N/A	N/A
bench_hmr_to_eval/Turbopack CSR/1000 modules	15.48ms ± 0.02ms	N/A	N/A	N/A
bench_startup/Turbopack CSR/1000 modules	2943.12ms ± 18.36ms	N/A	N/A	N/A

Note: depends on next Turbopack publish vercel/turborepo#5487 exports a reusable `handle_issues` function for reporting issues and erroring when failing issues are encountered. This uses it for `next build` with a failing severity level of error.

Depends on #5487 This implements a basic version of `turbopack build`, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node. Test Plan: `cargo run -p turbopack-cli build` with a `src/index.js` present and `cargo run -p turbopack-cli build src/entry.js` with `src/entry.js` present.

* vercel/turborepo#5567  * vercel/turborepo#5576  * vercel/turborepo#5503  * vercel/turborepo#5487  * vercel/turborepo#5488  * vercel/turborepo#5450  --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Note: depends on next Turbopack publish vercel/turborepo#5487 exports a reusable `handle_issues` function for reporting issues and erroring when failing issues are encountered. This uses it for `next build` with a failing severity level of error.

…borepo#5487) This work prepares for `turbopack build` by extracting code common between dev and build, such as asset context. This also makes the cli accept a variadic list of entries rather than an unnamed directory parameter. The project directory is now available under `--dir` or `-d`. Test Plan: `cargo run -p turbopack-cli dev` with a `src/index.js` present and `cargo run -p turbopack-cli dev src/entry.js` with `src/entry.js` present.

Depends on vercel/turborepo#5487 This implements a basic version of `turbopack build`, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node. Test Plan: `cargo run -p turbopack-cli build` with a `src/index.js` present and `cargo run -p turbopack-cli build src/entry.js` with `src/entry.js` present.

…borepo#5487) This work prepares for `turbopack build` by extracting code common between dev and build, such as asset context. This also makes the cli accept a variadic list of entries rather than an unnamed directory parameter. The project directory is now available under `--dir` or `-d`. Test Plan: `cargo run -p turbopack-cli dev` with a `src/index.js` present and `cargo run -p turbopack-cli dev src/entry.js` with `src/entry.js` present.

Depends on vercel/turborepo#5487 This implements a basic version of `turbopack build`, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node. Test Plan: `cargo run -p turbopack-cli build` with a `src/index.js` present and `cargo run -p turbopack-cli build src/entry.js` with `src/entry.js` present.

…borepo#5487) This work prepares for `turbopack build` by extracting code common between dev and build, such as asset context. This also makes the cli accept a variadic list of entries rather than an unnamed directory parameter. The project directory is now available under `--dir` or `-d`. Test Plan: `cargo run -p turbopack-cli dev` with a `src/index.js` present and `cargo run -p turbopack-cli dev src/entry.js` with `src/entry.js` present.

Depends on vercel/turborepo#5487 This implements a basic version of `turbopack build`, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node. Test Plan: `cargo run -p turbopack-cli build` with a `src/index.js` present and `cargo run -p turbopack-cli build src/entry.js` with `src/entry.js` present.

wbinnssmith requested review from a team as code owners July 10, 2023 20:06

wbinnssmith requested review from chris-olszewski and NicholasLYang July 10, 2023 20:06

turbo-orchestrator bot added team: turbopack labels Jul 10, 2023

vercel bot deployed to Preview – turbo-site July 10, 2023 20:07 View deployment

wbinnssmith added 2 commits July 10, 2023 13:09

fixup! turbopack-cli: modularize code to support turbopack build

2916a58

fixup! fixup! turbopack-cli: modularize code to support turbopack build

1487140

wbinnssmith mentioned this pull request Jul 10, 2023

WEB-1253: turbopack-cli: implement turbopack build #5488

Merged

Merge remote-tracking branch 'origin/main' into wbinnssmith/modulariz…

c49d929

…e-cli

turbo-orchestrator bot removed the team: turborepo label Jul 10, 2023

fixup! turbopack-cli: modularize code to support turbopack build

9f1b0f0

arlyon approved these changes Jul 11, 2023

View reviewed changes

sokra approved these changes Jul 12, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into wbinnssmith/modulariz…

6c9079d

…e-cli

vercel bot deployed to Preview – examples-vite-web July 12, 2023 17:50 View deployment

vercel bot deployed to Preview – examples-tailwind-web July 12, 2023 17:50 View deployment

vercel bot deployed to Preview – examples-cra-web July 12, 2023 17:50 View deployment

vercel bot deployed to Preview – examples-svelte-web July 12, 2023 17:50 View deployment

vercel bot deployed to Preview – examples-designsystem-docs July 12, 2023 17:50 View deployment

vercel bot deployed to Preview – examples-gatsby-web July 12, 2023 17:50 View deployment

vercel bot deployed to Preview – examples-kitchensink-blog July 12, 2023 17:50 View deployment

vercel bot deployed to Preview – examples-nonmonorepo July 12, 2023 17:50 View deployment

vercel bot deployed to Preview – examples-basic-web July 18, 2023 17:19 View deployment

vercel bot deployed to Preview – examples-gatsby-web July 18, 2023 17:19 View deployment

vercel bot deployed to Preview – examples-native-web July 18, 2023 17:19 View deployment

vercel bot deployed to Preview – turbo-site July 18, 2023 17:20 View deployment

fixup! Merge remote-tracking branch 'origin/main' into wbinnssmith/mo…

de9b98d

…dularize-cli

wbinnssmith added 3 commits July 18, 2023 14:50

fixup! fixup! Merge remote-tracking branch 'origin/main' into wbinnss…

cb3b1a4

…mith/modularize-cli

Merge remote-tracking branch 'origin/main' into wbinnssmith/modulariz…

282fead

…e-cli

fixup! Merge remote-tracking branch 'origin/main' into wbinnssmith/mo…

d41b4e0

…dularize-cli

vercel bot deployed to Preview – turbo-site July 19, 2023 17:49 View deployment

fixup! fixup! Merge remote-tracking branch 'origin/main' into wbinnss…

6edac0f

…mith/modularize-cli

wbinnssmith merged commit 046ea29 into main Jul 20, 2023
35 of 37 checks passed

wbinnssmith deleted the wbinnssmith/modularize-cli branch July 20, 2023 21:43

wbinnssmith mentioned this pull request Jul 20, 2023

Next build: use exported handle_issues from turbopack vercel/next.js#52972

Merged

sokra mentioned this pull request Jul 21, 2023

update Turbopack vercel/next.js#52986

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

turbopack-cli: modularize code to support turbopack build #5487

turbopack-cli: modularize code to support turbopack build #5487

wbinnssmith commented Jul 10, 2023

vercel bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023

arlyon left a comment

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 20, 2023

github-actions bot commented Jul 20, 2023

github-actions bot commented Jul 20, 2023

turbopack-cli: modularize code to support turbopack build #5487

turbopack-cli: modularize code to support turbopack build #5487

Conversation

wbinnssmith commented Jul 10, 2023

vercel bot commented Jul 10, 2023 • edited Loading

github-actions bot commented Jul 10, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Jul 10, 2023 • edited Loading

github-actions bot commented Jul 10, 2023

Linux Benchmark for cdf562d

arlyon left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 18, 2023

Linux Benchmark for 3faad6f

github-actions bot commented Jul 19, 2023

Linux Benchmark for d717989

github-actions bot commented Jul 19, 2023

MacOS Benchmark for d717989

github-actions bot commented Jul 20, 2023

Linux Benchmark for 17be234

github-actions bot commented Jul 20, 2023

MacOS Benchmark for 17be234

github-actions bot commented Jul 20, 2023

Windows Benchmark for 17be234

vercel bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

Linux Benchmark for `3faad6f`

Linux Benchmark for `d717989`

MacOS Benchmark for `d717989`

Linux Benchmark for `17be234`

MacOS Benchmark for `17be234`

Windows Benchmark for `17be234`