Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(turbopack): run daily with --experimental #5648

Merged
merged 1 commit into from
Aug 2, 2023
Merged

test(turbopack): run daily with --experimental #5648

merged 1 commit into from
Aug 2, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jul 31, 2023 •
edited by sokra
Loading

Description

switch the daily next integration test run to use --experimental-turbo

@vercel
Copy link

vercel bot commented Jul 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 4:23am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 4:23am
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 4:23am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 4:23am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 4:23am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 4:23am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 4:23am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 4:23am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 4:23am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 4:23am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 4:23am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 56f8ca1 to 4562430 Compare July 31, 2023 17:16
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 4562430 to 3a150c1 Compare July 31, 2023 18:48
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 3a150c1 to 873dc09 Compare July 31, 2023 19:10
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 873dc09 to 48187b5 Compare July 31, 2023 21:01
@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

Linux Benchmark for 0e1b85d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6099.02µs ± 24.37µs 6109.61µs ± 17.09µs +0.17%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5611.34µs ± 17.87µs 6102.41µs ± 509.26µs +8.75%
bench_startup/Turbopack CSR/1000 modules 997.94ms ± 1.55ms 1000.42ms ± 5.19ms +0.25%

@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 48187b5 to aa4f348 Compare July 31, 2023 21:33
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from aa4f348 to 6204cf9 Compare July 31, 2023 21:50
@github-actions
Copy link
Contributor

Linux Benchmark for 04451c2

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5391.35µs ± 25.79µs 5340.84µs ± 25.72µs -0.94%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5043.70µs ± 22.91µs 5123.88µs ± 118.69µs +1.59%
bench_startup/Turbopack CSR/1000 modules 984.06ms ± 1.03ms 976.77ms ± 3.06ms -0.74%

@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 6204cf9 to 56f23cd Compare July 31, 2023 22:18
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 56f23cd to 13cf01c Compare July 31, 2023 22:20
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 13cf01c to ca17520 Compare July 31, 2023 22:31
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from ca17520 to f88c88d Compare July 31, 2023 22:45
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from f88c88d to cac9d80 Compare July 31, 2023 23:02
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from cac9d80 to 4c63c78 Compare July 31, 2023 23:12
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 4c63c78 to 68c9c76 Compare July 31, 2023 23:28
@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from 68c9c76 to affd3b8 Compare July 31, 2023 23:44
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Linux Benchmark for 4defd8a

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5393.21µs ± 16.72µs 5403.61µs ± 21.49µs +0.19%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5057.70µs ± 23.48µs 5533.01µs ± 548.32µs +9.40%
bench_startup/Turbopack CSR/1000 modules 985.06ms ± 0.69ms 988.65ms ± 4.27ms +0.36%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

MacOS Benchmark for 4defd8a

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.94ms ± 0.11ms 24.11ms ± 0.43ms -10.50% -6.54%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.94ms ± 0.11ms 24.11ms ± 0.43ms -10.50% -6.54%
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.52ms ± 0.82ms 43.19ms ± 9.74ms +76.12%
bench_startup/Turbopack CSR/1000 modules 4288.16ms ± 833.63ms 3747.61ms ± 51.00ms -12.61%

@kwonoj kwonoj force-pushed the test-daily-experimental-turbo branch from affd3b8 to ba7b7b5 Compare August 1, 2023 04:22
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Linux Benchmark for 7e6f83d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6213.81µs ± 28.20µs 6213.51µs ± 38.97µs -0.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5768.53µs ± 53.86µs 5896.92µs ± 137.18µs +2.23%
bench_startup/Turbopack CSR/1000 modules 1000.92ms ± 2.53ms 1002.79ms ± 4.10ms +0.19%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Windows Benchmark for 7e6f83d

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 3639.48ms ± 14.97ms 3561.23ms ± 8.85ms -2.15% -0.85%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.58ms ± 0.05ms 15.62ms ± 0.05ms +0.24%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.50ms ± 0.01ms 15.47ms ± 0.01ms -0.17%
bench_startup/Turbopack CSR/1000 modules 3639.48ms ± 14.97ms 3561.23ms ± 8.85ms -2.15% -0.85%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

MacOS Benchmark for 7e6f83d

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 3902.17ms ± 115.38ms 14.44s ± 1.37s +270.14% +183.34%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.78ms ± 0.09ms 27.78ms ± 0.05ms +0.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.72ms ± 1.10ms 26.30ms ± 0.27ms +6.39%
bench_startup/Turbopack CSR/1000 modules 3902.17ms ± 115.38ms 14.44s ± 1.37s +270.14% +183.34%

@kwonoj kwonoj changed the title [WIP] test(turbopack): run daily with --experimental test(turbopack): run daily with --experimental Aug 1, 2023
@kwonoj kwonoj marked this pull request as ready for review August 1, 2023 22:21
@kwonoj kwonoj requested review from a team as code owners August 1, 2023 22:21
@sokra sokra merged commit eef7365 into main Aug 2, 2023
120 of 127 checks passed
@sokra sokra deleted the test-daily-experimental-turbo branch August 2, 2023 13:05
@sokra sokra mentioned this pull request Aug 3, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Aug 4, 2023
@sokra
update turbopack (#53545)
4ea1d8a 
* vercel/turborepo#5582 
* vercel/turborepo#5633 
* vercel/turborepo#5637 
* vercel/turborepo#5648 <!-- OJ Kwon - test(turbopack): run daily with --experimental  -->
* vercel/turborepo#5618 
* vercel/turborepo#5624 
* vercel/turborepo#5597 
* vercel/turborepo#5632 
* vercel/turborepo#5636 
* vercel/turborepo#5666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@arlyon arlyon arlyon approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwonoj @sokra @arlyon