Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust toolchain #5739

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Update rust toolchain #5739

merged 5 commits into from
Aug 17, 2023

Conversation

jridgewell
Copy link
Contributor

@jridgewell jridgewell commented Aug 16, 2023 •
edited by padmaia
Loading

The current toolchain is very buggy.

Closes WEB-1405

@jridgewell jridgewell requested review from a team as code owners August 16, 2023 16:29
@vercel
Copy link

vercel bot commented Aug 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 9:24pm
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 9:24pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 9:24pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 9:24pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 9:24pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 9:24pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 9:24pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 9:24pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 9:24pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 9:24pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 9:24pm

@jridgewell jridgewell added the pr: automerge Kodiak will merge these automatically after checks pass label Aug 16, 2023
@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

Linux Benchmark for 4532b3e

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5385.74µs ± 20.78µs 5391.19µs ± 20.96µs +0.10%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5055.10µs ± 28.52µs 5251.95µs ± 279.80µs +3.89%
bench_startup/Turbopack CSR/1000 modules 1001.45ms ± 2.07ms 1001.17ms ± 2.18ms -0.03%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for 7d64cc3

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 1073.81ms ± 2.01ms 1101.76ms ± 5.82ms +2.60% +1.14%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7571.90µs ± 10.00µs 7578.99µs ± 21.48µs +0.09%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6917.71µs ± 12.13µs 7134.81µs ± 278.95µs +3.14%
bench_startup/Turbopack CSR/1000 modules 1073.81ms ± 2.01ms 1101.76ms ± 5.82ms +2.60% +1.14%

@github-actions
Copy link
Contributor

Linux Benchmark for 46aa308

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6004.32µs ± 40.02µs 6104.84µs ± 47.85µs +1.67%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5431.78µs ± 37.17µs 5675.71µs ± 112.83µs +4.49%
bench_startup/Turbopack CSR/1000 modules 1014.85ms ± 1.85ms 1018.08ms ± 3.60ms +0.32%

@github-actions
Copy link
Contributor

MacOS Benchmark for 46aa308

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.08ms ± 0.07ms 29.04ms ± 0.84ms +7.25% +0.48%
bench_startup/Turbopack CSR/1000 modules 3402.27ms ± 18.54ms 3653.83ms ± 85.61ms +7.39% +1.26%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.08ms ± 0.07ms 29.04ms ± 0.84ms +7.25% +0.48%
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.07ms ± 0.39ms 25.56ms ± 0.36ms -1.93%
bench_startup/Turbopack CSR/1000 modules 3402.27ms ± 18.54ms 3653.83ms ± 85.61ms +7.39% +1.26%

@github-actions
Copy link
Contributor

Linux Benchmark for 3c65ec9

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5305.78µs ± 18.96µs 5276.13µs ± 20.84µs -0.56%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4939.47µs ± 33.77µs 4999.55µs ± 63.78µs +1.22%
bench_startup/Turbopack CSR/1000 modules 989.17ms ± 1.32ms 990.37ms ± 2.74ms +0.12%

@github-actions
Copy link
Contributor

Linux Benchmark for 4c4c171

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5933.32µs ± 34.38µs 5995.98µs ± 38.60µs +1.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5464.72µs ± 46.82µs 5571.12µs ± 53.26µs +1.95%
bench_startup/Turbopack CSR/1000 modules 1001.29ms ± 2.34ms 1000.24ms ± 3.85ms -0.11%

@github-actions
Copy link
Contributor

Windows Benchmark for 4c4c171

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 2699.77ms ± 8.34ms 2652.79ms ± 4.85ms -1.74% -0.77%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 16.40ms ± 0.62ms 15.47ms ± 0.02ms -5.67%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.45ms ± 0.02ms 15.45ms ± 0.01ms +0.04%
bench_startup/Turbopack CSR/1000 modules 2699.77ms ± 8.34ms 2652.79ms ± 4.85ms -1.74% -0.77%

@github-actions
Copy link
Contributor

MacOS Benchmark for 4c4c171

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.46ms ± 0.27ms 22.44ms ± 0.73ms -11.86% -4.14%
bench_startup/Turbopack CSR/1000 modules 10.22s ± 2.39s 3400.78ms ± 111.65ms -66.72% -33.38%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.56ms ± 0.10ms 26.62ms ± 0.05ms +0.21%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.46ms ± 0.27ms 22.44ms ± 0.73ms -11.86% -4.14%
bench_startup/Turbopack CSR/1000 modules 10.22s ± 2.39s 3400.78ms ± 111.65ms -66.72% -33.38%

@jridgewell jridgewell merged commit 8eb6a7e into main Aug 17, 2023
64 of 66 checks passed
@jridgewell jridgewell deleted the jrl-toolchain branch August 17, 2023 16:09
@sokra sokra mentioned this pull request Aug 25, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Aug 25, 2023
@sokra
update turbopack (#54558)
08d3258 
* vercel/turborepo#5723 <!-- Alex Kirszenberg - Misc
comments in turbo_tasks -->
* vercel/turborepo#5714 <!-- OJ Kwon - test(ci):
update datadog-ci -->
* vercel/turborepo#5705 <!-- Justin Ridgewell -
Transformation code necessary to support Server Actions -->
* vercel/turborepo#5739 <!-- Justin Ridgewell -
Update rust toolchain -->
* vercel/turborepo#5785 <!-- Tobias Koppers - add
evaluatables to chunk list ident -->
* vercel/turborepo#5783 <!-- Tobias Koppers -
Tracing improvements -->
* vercel/turborepo#5738 <!-- Alex Kirszenberg -
Generic types over Vcs -->
* vercel/turborepo#5795 <!-- Leah - fix: snapshot
test path canonicalization -->
* vercel/turborepo#5794 <!-- Tobias Koppers - fix
"any" context condition implementation -->
* vercel/turborepo#5800 <!-- Tobias Koppers - add
middleware entry type -->
* vercel/turborepo#5786 <!-- Tobias Koppers -
perform invalidation directly on writes -->

Closes WEB-1446
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@jridgewell
Update rust toolchain (vercel/turborepo#5739)
c2d0614 
The current toolchain is very buggy.

Closes WEB-1405
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@jridgewell
Update rust toolchain (vercel/turborepo#5739)
10c901f 
The current toolchain is very buggy.

Closes WEB-1405
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@jridgewell
Update rust toolchain (vercel/turborepo#5739)
d3210a2 
The current toolchain is very buggy.

Closes WEB-1405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@alexkirsz alexkirsz alexkirsz approved these changes

@NicholasLYang NicholasLYang NicholasLYang approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci created-by: turbopack owned-by: turbopack owned-by: turborepo pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jridgewell @wbinnssmith @alexkirsz @NicholasLYang @padmaia