Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(example): basic example react version in ui package #5757

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix(example): basic example react version in ui package #5757

merged 1 commit into from
Aug 21, 2023

Conversation

anmol242
Copy link
Contributor

@anmol242 anmol242 commented Aug 19, 2023 •
edited
Loading

Description

This PR fixes the issue mentioned in #5756

Corrected version of react same as web and docs app so that we don't have to manually change react version while installing boiler plate on turbo

Testing Instructions

  • Install basic boiler plate of turbo app. UI package will use the same react version which is used by web and docs app

@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples owned-by: turborepo labels Aug 19, 2023
@vercel
Copy link

vercel bot commented Aug 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ❌ Failed (Inspect) Aug 19, 2023 2:58pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 19, 2023 2:58pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 19, 2023 2:58pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 19, 2023 2:58pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Aug 19, 2023 2:58pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2023 2:58pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2023 2:58pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2023 2:58pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2023 2:58pm

@vercel
Copy link

vercel bot commented Aug 19, 2023

@anmol242 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@anmol242 anmol242 changed the title fix: basic example react version in ui package fix(example): basic example react version in ui package Aug 19, 2023
@anmol242 anmol242 marked this pull request as ready for review August 19, 2023 15:11
@anmol242 anmol242 requested a review from a team as a code owner August 19, 2023 15:11
@anmol242 anmol242 mentioned this pull request Aug 21, 2023
Closed
@anmol242
Copy link
Contributor Author

Hey @tknickman and @chris-olszewski can I get a review on this PR?

tknickman
tknickman approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tknickman tknickman enabled auto-merge (squash) August 21, 2023 13:22
@tknickman tknickman merged commit 0ae8e36 into vercel:main Aug 21, 2023
41 of 44 checks passed
This was referenced Aug 21, 2023
Closed
Closed
@renovate renovate bot mentioned this pull request Sep 17, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman tknickman approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: examples Improvements or additions to examples owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmol242 @tknickman