fix(turborepo): Rust integration test fixes #6142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
|
✅ This change can build |
Linux Benchmark for e644d6b
Click to view full benchmark
|
|
mehulkar
reviewed
Oct 11, 2023
NicholasLYang
force-pushed
the
fix/rust-integration-test-fixes
branch
from
b54d791 to
1a1e611
Compare
🟢 Turbopack Benchmark CI successful 🟢Thanks |
chris-olszewski
approved these changes
Oct 19, 2023
NicholasLYang
force-pushed
the
fix/rust-integration-test-fixes
branch
from
1a1e611 to
6cdc9a6
Compare
mehulkar
reviewed
Oct 19, 2023
| @@ -332,6 +332,35 @@ jobs: | |||
| - name: Integration Tests | |||
| run: turbo run test --filter=turborepo-tests-integration --color --env-mode=strict --token=${{ secrets.TURBO_TOKEN }} --team=${{ vars.TURBO_TEAM }} | |||
|
|
|||
| turborepo_integration_rust: | |||
There was a problem hiding this comment.
Can this be matrixed into the job above? It's 90% the same. An if: {{matrix.codepath == "rust"}} shuold do the trick to change the command that runs?
There was a problem hiding this comment.
We don't want this to be blocking, so I think a second job is best
There was a problem hiding this comment.
Why not make it blocking? Seems like we're close to the end and should make it blocking at some point
NicholasLYang
force-pushed
the
fix/rust-integration-test-fixes
branch
2 times, most recently
from
e4a2900 to
9696b12
Compare
NicholasLYang
force-pushed
the
fix/rust-integration-test-fixes
branch
from
9696b12 to
1e3ff59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Closes TURBO-1442