implement basic side effects optimization #6590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
Linux Benchmark for 24c112bClick to view benchmark
|
Comment on lines
64
to
68
| self.inner() | ||
| .await? | ||
| .into_iter() | ||
| .map(|&inner| Vc::upcast(InternalCssAssetReference::new(inner))) | ||
| .collect(), |
There was a problem hiding this comment.
into_iter and collect here is kinda confusing
makes it look like inner returns multiple items instead of an option
same thing in other places in this PR
Linux Benchmark for 7d2bb95Click to view benchmark
|
ForsakenHarmony
suggested changes
Nov 27, 2023
same |
Linux Benchmark for eb330baClick to view benchmark
|
| let inner = self | ||
| .inner() | ||
| .await? | ||
| .context("inner asset should be CSS processable")?; |
There was a problem hiding this comment.
still not sure about this, I guess right now this can't happen
but if it does it would just throw a random error not telling you what the inner asset was and why it's not processable
Linux Benchmark for 9212a80Click to view benchmark
|
sokra
force-pushed
the
sokra/side-effects-optimization
branch
from
438eff4 to
e95f73b
Compare
Linux Benchmark for 9e7bbcdClick to view benchmark
|
sokra
force-pushed
the
sokra/side-effects-optimization
branch
from
13d5147 to
d0f389d
Compare
Linux Benchmark for ac33c8aClick to view benchmark
|
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Dec 6, 2023
### What? Code update for refactoring in vercel/turborepo#6590 Closes PACK-2043
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description * optimizes reexports for modules that are inside of folders with a package.json that contains `"sideEffects": false` * For named reexports * skips resolving, reading, parsing, transforms, code generation and bundling for unrelated reexports * skips code generation and bundling for the module containing the followed reexport * For star reexports * skips code generation and bundling for unrelated reexports before the followed reexport * skips resolving, reading, parsing, transforms, code generation and bundling for unrelated reexports after the followed reexport * skips code generation and bundling for the module containing the followed reexport Follow-up work: * `sideEffects` in package.json also supports a glob. We need to support that too. * renaming exports is not yet supported. We need to create a naming module for that to avoid effects on the importer side. Closes PACK-2042
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * optimizes reexports for modules that are inside of folders with a package.json that contains `"sideEffects": false` * For named reexports * skips resolving, reading, parsing, transforms, code generation and bundling for unrelated reexports * skips code generation and bundling for the module containing the followed reexport * For star reexports * skips code generation and bundling for unrelated reexports before the followed reexport * skips resolving, reading, parsing, transforms, code generation and bundling for unrelated reexports after the followed reexport * skips code generation and bundling for the module containing the followed reexport Follow-up work: * `sideEffects` in package.json also supports a glob. We need to support that too. * renaming exports is not yet supported. We need to create a naming module for that to avoid effects on the importer side. Closes PACK-2042
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * optimizes reexports for modules that are inside of folders with a package.json that contains `"sideEffects": false` * For named reexports * skips resolving, reading, parsing, transforms, code generation and bundling for unrelated reexports * skips code generation and bundling for the module containing the followed reexport * For star reexports * skips code generation and bundling for unrelated reexports before the followed reexport * skips resolving, reading, parsing, transforms, code generation and bundling for unrelated reexports after the followed reexport * skips code generation and bundling for the module containing the followed reexport Follow-up work: * `sideEffects` in package.json also supports a glob. We need to support that too. * renaming exports is not yet supported. We need to create a naming module for that to avoid effects on the importer side. Closes PACK-2042
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description * optimizes reexports for modules that are inside of folders with a package.json that contains `"sideEffects": false` * For named reexports * skips resolving, reading, parsing, transforms, code generation and bundling for unrelated reexports * skips code generation and bundling for the module containing the followed reexport * For star reexports * skips code generation and bundling for unrelated reexports before the followed reexport * skips resolving, reading, parsing, transforms, code generation and bundling for unrelated reexports after the followed reexport * skips code generation and bundling for the module containing the followed reexport Follow-up work: * `sideEffects` in package.json also supports a glob. We need to support that too. * renaming exports is not yet supported. We need to create a naming module for that to avoid effects on the importer side. Closes PACK-2042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"sideEffects": falseFollow-up work:
sideEffectsin package.json also supports a glob. We need to support that too.Closes PACK-2042