Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recursion cycle when having a cycle of dynamic imports #7941

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 11, 2024

Description

Testing Instructions

Closes PACK-2938

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 3:27pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 3:27pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 11, 2024 3:27pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 11, 2024 3:27pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 11, 2024 3:27pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 11, 2024 3:27pm
examples-native-web ⬜️ Ignored (Inspect) Apr 11, 2024 3:27pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 11, 2024 3:27pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 11, 2024 3:27pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 11, 2024 3:27pm

Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs

error: failed to select a version for `swc_core`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=9cb07d15131589fc49ab64de132e91fe75b50db5#e9932619)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.90.30` are: 0.90.30

all possible versions conflict with previously selected packages.

  previously selected package `swc_core v0.90.24`
    ... which satisfies dependency `swc_core = "^0.90.24"` (locked to 0.90.24) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_core` which could resolve this conflict

See job summary for details

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 11, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 9d45eac into main Apr 11, 2024
45 of 47 checks passed
@sokra sokra deleted the sokra/dynamic-import-cycle branch April 11, 2024 15:27
sokra added a commit to vercel/next.js that referenced this pull request Apr 11, 2024
* vercel/turborepo#7409 <!-- hrmny - chore: add
parallel rust frontend and remove unused rust dependencies -->
* vercel/turborepo#7920 <!-- Tobias Koppers - remove
warning when there is no PostCSS config -->
* vercel/turborepo#7856 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.29` -->
* vercel/turborepo#7941 <!-- Tobias Koppers - fix
recursion cycle when having a cycle of dynamic imports -->
* vercel/turborepo#7943 <!-- Tobias Koppers - fix
HMR by removing chunks from chunk list hash -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…rborepo#7941)

### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2938
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…rborepo#7941)

### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2938
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…rborepo#7941)

### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2938
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…rborepo#7941)

### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants