Small tree shaking fix and test case update #8347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
sokra
commented
Jun 6, 2024
Comment on lines
25
to
33
| ## Item 3: Stmt 2, `Normal` | ||
|
|
||
| ```js | ||
| export { dog as DOG, cat }; | ||
|
|
||
| ``` | ||
|
|
||
| - Side effects | ||
| - Reads: `dog`, `cat` |
There was a problem hiding this comment.
@kdy1 The whole statement is pretty wrong.
It should not have side effects. It should not read vars. It shouldn't exist at all.
There was a problem hiding this comment.
But if it does not exist, dependency graph will be wrong I think
sokra
commented
Jun 6, 2024
Comment on lines
134
to
138
| ## Part 1 | ||
| ```js | ||
| export { DOG as DOG }; | ||
|
|
||
| ``` |
There was a problem hiding this comment.
@kdy1 This looks weird. It should import dog shouldn't it?
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
kdy1
approved these changes
Jun 7, 2024
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jun 7, 2024
* vercel/turborepo#8347 <!-- Tobias Koppers - Small tree shaking fix and test case update --> * vercel/turborepo#8348 <!-- Donny/강동윤 - fix: Apply `paren-remover` while minifying -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description avoid adding module evaluation to internal part imports add a broken test case update split-chunk test case to work and be more clear ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description avoid adding module evaluation to internal part imports add a broken test case update split-chunk test case to work and be more clear ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description avoid adding module evaluation to internal part imports add a broken test case update split-chunk test case to work and be more clear ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description avoid adding module evaluation to internal part imports add a broken test case update split-chunk test case to work and be more clear ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8347 <!-- Tobias Koppers - Small tree shaking fix and test case update --> * vercel/turborepo#8348 <!-- Donny/강동윤 - fix: Apply `paren-remover` while minifying -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
avoid adding module evaluation to internal part imports
add a broken test case
update split-chunk test case to work and be more clear
Testing Instructions