Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devlow-bench: add git branch and sha to datapoints #8602

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

wbinnssmith
Copy link
Member

This includes this information to datapoints sent to Datadog. Also addresses an issue where trailing newlines were added when these values were not read from GitHub Actions.

This includes this information to datapoints sent to Datadog. Also addresses an issue where trailing newlines were added when these values were not read from GitHub Actions.
@wbinnssmith wbinnssmith requested review from a team as code owners June 25, 2024 17:35
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:35pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:35pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:35pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:35pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:35pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:35pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:35pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:35pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 5:35pm

Copy link
Contributor

github-actions bot commented Jun 25, 2024

🟢 CI successful 🟢

Thanks

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@mehulkar mehulkar removed their request for review June 25, 2024 18:32
Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might also be nice to track if the checkout is dirty, but that'd just be gravy.

surewhynot

@wbinnssmith wbinnssmith merged commit 5e65580 into main Jun 26, 2024
58 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/devlow-datadog-git branch June 26, 2024 22:57
bgw added a commit to vercel/next.js that referenced this pull request Jul 3, 2024
Tobias Koppers - fix typo (vercel/turborepo#8619)
Benjamin Woodruff - Store aggregate read/execute count statistics
(vercel/turborepo#8286)
Tobias Koppers - box InProgress task state (vercel/turborepo#8644)
Tobias Koppers - Task Edges Set/List (vercel/turborepo#8624)
Benjamin Woodruff - Memory: Use `triomphe::Arc` for `SharedReference`
(vercel/turborepo#8622)
Will Binns-Smith - chore: release npm packages (vercel/turborepo#8614)
Will Binns-Smith - devlow-bench: add git branch and sha to datapoints
(vercel/turborepo#8602)

---

Fixes a `triomphe` package version conflict between turbopack and swc by
bumping it from 0.1.11 to 0.1.13.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…8602)

This includes this information to datapoints sent to Datadog. Also
addresses an issue where trailing newlines were added when these values
were not read from GitHub Actions.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…8602)

This includes this information to datapoints sent to Datadog. Also
addresses an issue where trailing newlines were added when these values
were not read from GitHub Actions.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…8602)

This includes this information to datapoints sent to Datadog. Also
addresses an issue where trailing newlines were added when these values
were not read from GitHub Actions.
wbinnssmith added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
This includes vercel/turborepo#8602, which adds git data to datapoints.
wbinnssmith added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
This includes vercel/turborepo#8602, which adds git
data to datapoints.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…8602)

This includes this information to datapoints sent to Datadog. Also
addresses an issue where trailing newlines were added when these values
were not read from GitHub Actions.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
Tobias Koppers - fix typo (vercel/turborepo#8619)
Benjamin Woodruff - Store aggregate read/execute count statistics
(vercel/turborepo#8286)
Tobias Koppers - box InProgress task state (vercel/turborepo#8644)
Tobias Koppers - Task Edges Set/List (vercel/turborepo#8624)
Benjamin Woodruff - Memory: Use `triomphe::Arc` for `SharedReference`
(vercel/turborepo#8622)
Will Binns-Smith - chore: release npm packages (vercel/turborepo#8614)
Will Binns-Smith - devlow-bench: add git branch and sha to datapoints
(vercel/turborepo#8602)

---

Fixes a `triomphe` package version conflict between turbopack and swc by
bumping it from 0.1.11 to 0.1.13.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
This includes vercel/turborepo#8602, which adds git
data to datapoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants