-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unloading stateful check #8749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
kdy1
approved these changes
Jul 15, 2024
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 16, 2024
* vercel/turborepo#8721 <!-- Tobias Koppers - fix equal checks for cells and output --> * vercel/turborepo#8671 <!-- Tobias Koppers - add unloading of tasks to GC --> * vercel/turborepo#8749 <!-- Tobias Koppers - fix unloading stateful check --> * vercel/turborepo#8750 <!-- Tobias Koppers - upgrade deps to avoid conflict with next.js -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description We need to move up the check so it prevents unloading tasks with state. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description We need to move up the check so it prevents unloading tasks with state. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description We need to move up the check so it prevents unloading tasks with state. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description We need to move up the check so it prevents unloading tasks with state. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8721 <!-- Tobias Koppers - fix equal checks for cells and output --> * vercel/turborepo#8671 <!-- Tobias Koppers - add unloading of tasks to GC --> * vercel/turborepo#8749 <!-- Tobias Koppers - fix unloading stateful check --> * vercel/turborepo#8750 <!-- Tobias Koppers - upgrade deps to avoid conflict with next.js -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to move up the check so it prevents unloading tasks with state.
Testing Instructions