Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(turbopack): support analysing string concatenation #8823

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

ForsakenHarmony
Copy link
Contributor

Description

Adds support for String.prototype.concat which dayjs uses in an import() pattern.

Testing Instructions

Closes PACK-3118
Fixes vercel/next.js#66826

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 0:44am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 0:44am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 0:44am
examples-designsystem-docs ⬜️ Ignored (Inspect) Jul 24, 2024 0:44am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 0:44am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jul 24, 2024 0:44am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 0:44am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 0:44am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 0:44am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 0:44am

Copy link
Contributor

github-actions bot commented Jul 23, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jul 23, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@ForsakenHarmony ForsakenHarmony merged commit 00039b9 into main Jul 24, 2024
58 of 60 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/pack-3118-string-concatenation branch July 24, 2024 14:20
sokra added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff -
Simplify some of the syntax used with VcRead<T> -->
* vercel/turborepo#8823 <!-- hrmny -
feat(turbopack): support analysing string concatenation -->
* vercel/turborepo#8828 <!-- Tobias Koppers - change
from failsafe_analyse to failsafe_parse -->
* vercel/turborepo#8831 <!-- Alexander Lyon - make
sure that all the taiki-e/install-action calls use our env -->
* vercel/turborepo#8819 <!-- Tobias Koppers -
Refactor cell reading to handle removed cells -->
* vercel/turborepo#8038 <!-- Alexander Lyon - add
tags to turbo tasks -->
* vercel/turborepo#8807 <!-- Tobias Koppers - box
Scheduled task state to save memory -->
* vercel/turborepo#8170 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…repo#8823)

### Description

Adds support for `String.prototype.concat` which `dayjs` uses in an
`import()` pattern.

### Testing Instructions

Closes PACK-3118
Fixes #66826
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…repo#8823)

### Description

Adds support for `String.prototype.concat` which `dayjs` uses in an
`import()` pattern.

### Testing Instructions

Closes PACK-3118
Fixes #66826
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…repo#8823)

### Description

Adds support for `String.prototype.concat` which `dayjs` uses in an
`import()` pattern.

### Testing Instructions

Closes PACK-3118
Fixes #66826
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…repo#8823)

### Description

Adds support for `String.prototype.concat` which `dayjs` uses in an
`import()` pattern.

### Testing Instructions

Closes PACK-3118
Fixes #66826
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff -
Simplify some of the syntax used with VcRead<T> -->
* vercel/turborepo#8823 <!-- hrmny -
feat(turbopack): support analysing string concatenation -->
* vercel/turborepo#8828 <!-- Tobias Koppers - change
from failsafe_analyse to failsafe_parse -->
* vercel/turborepo#8831 <!-- Alexander Lyon - make
sure that all the taiki-e/install-action calls use our env -->
* vercel/turborepo#8819 <!-- Tobias Koppers -
Refactor cell reading to handle removed cells -->
* vercel/turborepo#8038 <!-- Alexander Lyon - add
tags to turbo tasks -->
* vercel/turborepo#8807 <!-- Tobias Koppers - box
Scheduled task state to save memory -->
* vercel/turborepo#8170 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff -
Simplify some of the syntax used with VcRead<T> -->
* vercel/turborepo#8823 <!-- hrmny -
feat(turbopack): support analysing string concatenation -->
* vercel/turborepo#8828 <!-- Tobias Koppers - change
from failsafe_analyse to failsafe_parse -->
* vercel/turborepo#8831 <!-- Alexander Lyon - make
sure that all the taiki-e/install-action calls use our env -->
* vercel/turborepo#8819 <!-- Tobias Koppers -
Refactor cell reading to handle removed cells -->
* vercel/turborepo#8038 <!-- Alexander Lyon - add
tags to turbo tasks -->
* vercel/turborepo#8807 <!-- Tobias Koppers - box
Scheduled task state to save memory -->
* vercel/turborepo#8170 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff -
Simplify some of the syntax used with VcRead<T> -->
* vercel/turborepo#8823 <!-- hrmny -
feat(turbopack): support analysing string concatenation -->
* vercel/turborepo#8828 <!-- Tobias Koppers - change
from failsafe_analyse to failsafe_parse -->
* vercel/turborepo#8831 <!-- Alexander Lyon - make
sure that all the taiki-e/install-action calls use our env -->
* vercel/turborepo#8819 <!-- Tobias Koppers -
Refactor cell reading to handle removed cells -->
* vercel/turborepo#8038 <!-- Alexander Lyon - add
tags to turbo tasks -->
* vercel/turborepo#8807 <!-- Tobias Koppers - box
Scheduled task state to save memory -->
* vercel/turborepo#8170 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turbopack: --turbo couldn't dayjs molude resolution within cal-heatmap library.
2 participants