Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash correct file paths for global dependencies #888

Merged
merged 6 commits into from
Mar 16, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Mar 15, 2022

Fixes #886

GitHashForFiles now takes absolute paths for all files. It was previously receiving a mix of absolute and relative paths. Also clean up execution of git hash-objects a little.

@vercel
Copy link

vercel bot commented Mar 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/4KiV8MFNVb1D7RcprWwx5T71HmD8
✅ Preview: https://turbo-site-git-gsoltis-fixglobaldepspath.vercel.sh

@gsoltis gsoltis marked this pull request as ready for review March 16, 2022 00:05
@gsoltis gsoltis requested a review from gaspar09 as a code owner March 16, 2022 00:05
@jaredpalmer
Copy link
Contributor

This looks great, let's fix errors in #891 and then merge these up

Normalize paths coming from ls tree
@kodiakhq kodiakhq bot merged commit 839e698 into main Mar 16, 2022
@jaredpalmer jaredpalmer deleted the gsoltis/fix_global_deps_path branch March 16, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

globalDependencies not taken into account for files in the root folder
2 participants