Support Buffer results from Webpack loaders #8902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
sokra
reviewed
Aug 1, 2024
| @@ -479,7 +479,7 @@ const transform = ( | |||
| if (!result.result) return reject(new Error("No result from loaders")); | |||
| const [source, map] = result.result; | |||
| resolve({ | |||
| source, | |||
| source: Buffer.isBuffer(source) ? source.toString("utf8") : source, | |||
There was a problem hiding this comment.
The result might be some binary data that is not an utf-8 string.
E. g. some image-processing-loader can return an image.
|
|
Added to vercel/next.js#68397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result from a webpack loader can be a string or a buffer: https://webpack.js.org/api/loaders/#thiscallback
The mdx loader uses this:
https://github.com/mdx-js/mdx/blob/e780a972c29584851c2a131f2984a7470aa8c2f2/packages/loader/lib/index.js#L93
Stringify the Buffer before sending it over to Rust