Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid JSON #9109

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix invalid JSON #9109

merged 1 commit into from
Sep 4, 2024

Conversation

AlexErrant
Copy link
Contributor

@AlexErrant AlexErrant commented Sep 4, 2024

More or less a typo fix.

Also, what does "topo" mean? Searching the docs for "topo" yields nothing, and searching the repo yields

turborepo/turbo.json

Lines 215 to 219 in a8f38f1

// This is a synthetic tasks that lets us pull in other workspaces as dependencies
// So changes in internal workspaces that we depend on, will trigger this task.
"topo": {
"dependsOn": ["^topo"]
}

Why should check-types depend on topo? The docs point me to "Transit Nodes", but I'm still confused. In particular,

Turborepo calls the ui package a Transit Node in this scenario, because it doesn't have its own build script.

So should we not have a topo script? If this is the case, why do other turbo.json files in this repo have a topo task (which does nothing; see below)?

Also, this repo's own check-types doesn't depend on topo. This is especially confusing when combined with this comment I found

"tasks": {
// This needs to exist because upstream packages depend on it and
// it's not defined at the root level.
"topo": {},

because uh... the root turbo.json does have a topo task (see above).

I'm a turborepo noob so perhaps I'm missing something obvious, but I'm filled with confusion while trying to setup Typescript right now 😢.

fix invalid json
@AlexErrant AlexErrant requested review from anthonyshew and a team as code owners September 4, 2024 21:59
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Sep 4, 2024
Copy link

vercel bot commented Sep 4, 2024

@AlexErrant is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 13 seconds (more than 300, code: "api-deployments-flood-enterprise").

Copy link

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 14 seconds (more than 300, code: "api-deployments-flood-enterprise").

Copy link

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 15 seconds (more than 300, code: "api-deployments-flood-enterprise").

Copy link

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 17 seconds (more than 300, code: "api-deployments-flood-enterprise").

Copy link

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 22 seconds (more than 300, code: "api-deployments-flood-enterprise").

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthonyshew anthonyshew merged commit 8461559 into vercel:main Sep 4, 2024
3 of 12 checks passed
@AlexErrant AlexErrant deleted the patch-1 branch September 4, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants