chore(config): move all uses of clap(env) to config
#9113
Merged
+249
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
requested review from
tknickman and
dimitropoulos
and removed request for
a team
NicholasLYang
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an effort to get us where we're able to identify if there are multiple copies of run args* present this PR moves uses of
clap(env)toconfig/env.rs. This also prepares us if we want to add some of these options toturbo.json.Each commit of this PR should be reviewed on it's own. The first chunk of this PR is some refactors to the config setup to reduce the copy-pasta of adding more env vars.
Explanation of
clap(env)issueEnv vars being parsed at the CLI level results in problems for us as
TURBO_LOG_ORDER=grouped turbo run build --log-order streamis totally valid command where we should stream logs, but it will result inargs.execution_args.log_order = LogOrder::Groupedandargs.command.execution_args.log_order = LogOrder::Streamand we can't tell if this is from env var usage or if the user typedturbo --log-order=grouped run build --log-order=stream.Testing Instructions
Existing unit tests.
Manually checking all of the changed flags/env vars e.g.