Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-turbo): Require specific argument for example option #9147

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

islandryu
Copy link
Contributor

Description

When we forgot to add the example argument in create-turbo, example was treated as true.
The error log below makes me a little confused.

vscode ➜ /workspaces $ npx create-turbo -e
Need to install the following packages:
create-turbo@2.1.2
Ok to proceed? (y) 

? Where would you like to create your Turborepo? ./my-turborepo
? Which package manager do you want to use? npm
>>> Could not locate an example named "true". It could be due to the following:
 1. Your spelling of example "true" might be incorrect.
 2. You might not be connected to the internet or you are behind a proxy.

I couldn't find a reason why the example argument is optional, so I'm making it require.

vscode ➜ /workspaces/turborepo (fix/create-turbo) $ ./packages/create-turbo/dist/cli.js -e
error: option '-e, --example <name>|<github-url>' argument missing

Testing Instructions

We can check the changes by running the CLI itself.
Alternatively, if testing is required at the Commander level, I can implement it.

./packages/create-turbo/dist/cli.js -e

@islandryu islandryu requested a review from a team as a code owner September 15, 2024 14:58
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo pkg: create-turbo Issues related to npx create-turbo labels Sep 15, 2024
Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 0:02am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 0:02am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 0:02am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 0:02am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 0:02am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 0:02am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 0:02am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 0:02am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 0:02am

Copy link

vercel bot commented Sep 15, 2024

@islandryu is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ijjk
Copy link
Member

ijjk commented Sep 16, 2024

Allow CI Workflow Run

  • approve CI run for commit: f6efc9d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Sep 16, 2024

Allow CI Workflow Run

  • approve CI run for commit: f6efc9d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@chris-olszewski chris-olszewski merged commit f7aeea6 into vercel:main Sep 16, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turborepo pkg: create-turbo Issues related to npx create-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants