Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): add array type #9161

Merged
merged 3 commits into from
Sep 17, 2024
Merged

feat(query): add array type #9161

merged 3 commits into from
Sep 17, 2024

Conversation

NicholasLYang
Copy link
Contributor

Description

Added an Array type that automatically adds a length and items field to GraphQL responses.

Testing Instructions

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 8:33pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 8:33pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 8:33pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 8:33pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 8:33pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 8:33pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 8:33pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 8:33pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 8:33pm

Comment on lines 47 to 48
unsafe impl<T: Send + OutputType> Send for Array<T> {}
unsafe impl<T: Sync + OutputType> Sync for Array<T> {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these necessary? Rust should be automatically implementing these if all fields are Send/Sync

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this to approve to unblock, but I do think that the unsafe impls should be removed.

@NicholasLYang NicholasLYang enabled auto-merge (squash) September 17, 2024 20:33
@NicholasLYang NicholasLYang merged commit c482ce3 into main Sep 17, 2024
39 checks passed
@NicholasLYang NicholasLYang deleted the nicholasyang/query-updates branch September 17, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants