Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base.json is extended by other tsconfig.json, not package.json #9189

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

boutchitos
Copy link
Contributor

Description

In Use a base tsconfig file, it is state that base.json, a TypeScript config file, is extended by every other package.json. I guess we should say extended by every other tsconfig.json in the workspace.

@boutchitos boutchitos requested review from anthonyshew and a team as code owners September 26, 2024 18:21
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Sep 26, 2024
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:22pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:22pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:22pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:22pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:22pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:22pm

Copy link

vercel bot commented Sep 26, 2024

@boutchitos is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@anthonyshew anthonyshew merged commit 663d3ff into vercel:main Sep 26, 2024
9 of 12 checks passed
@boutchitos boutchitos deleted the extended-by-tsconfig-fix branch September 26, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants